Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Table] Inverted Table fixes for sortable header and disabled colored rows/cells #579

Merged
merged 1 commit into from
Mar 26, 2019

Conversation

lubber-de
Copy link
Member

@lubber-de lubber-de commented Mar 22, 2019

Description

A few fixes for inverted table

  • sortable table header still had black text color
  • disabled rows or cells on (also) colored rows/cells had unreadable text color
  • celled cells still had the same, thus too dark, left cell border from the non-inverted variant

Testcase

https://jsfiddle.net/63g1y07j/5/

Remove CSS to see issues

Screenshot

Broken

image

Fixed

image

Closes

Semantic-Org/Semantic-UI#6778

…per display of inverted cells on colored rows and fix inverted celled border
@lubber-de lubber-de added lang/css Anything involving CSS state/awaiting-reviews Pull requests which are waiting for reviews tag/sui-issue Taken from an existing Issue/PR of SUI 🐛 bugfix labels Mar 22, 2019
@lubber-de lubber-de added this to the 2.7.4 milestone Mar 22, 2019
@lubber-de lubber-de changed the title [Table] increase specificity for sortable inverted header and pro… [Table] Inverted Table fixes for sortable header and disabled colored rows/cells Mar 22, 2019
Copy link
Member

@y0hami y0hami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@prudho prudho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@y0hami y0hami removed the state/awaiting-reviews Pull requests which are waiting for reviews label Mar 26, 2019
@y0hami y0hami modified the milestones: 2.7.4, 2.7.3 Mar 26, 2019
@y0hami y0hami merged commit 7bd4adb into fomantic:develop Mar 26, 2019
@lubber-de lubber-de deleted the fix/6778/inverted_table_fixes branch March 26, 2019 13:38
@y0hami y0hami mentioned this pull request Apr 1, 2019
@exoego exoego added type/bug Any issue which is a bug or PR which fixes a bug and removed 🐛 bugfix labels May 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lang/css Anything involving CSS tag/sui-issue Taken from an existing Issue/PR of SUI type/bug Any issue which is a bug or PR which fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants