Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Progress] Allow multiple bars #582

Merged
merged 10 commits into from
Mar 26, 2019
Merged

[Progress] Allow multiple bars #582

merged 10 commits into from
Mar 26, 2019

Conversation

exoego
Copy link
Contributor

@exoego exoego commented Mar 23, 2019 •
edited
Loading

Description

Allow progress modue to have multiple bars.

  • data-percent and data-value are extended to have multiple values like data-pecent="30,0,70"
  • Bar of 0 width are hidden for readability.
  • {bar} placeholder are added to indicate name of bars so that end-users can ditinguish bars.

Screenshot (when possible)

image

Closes

Semantic-Org/Semantic-UI#6160

@exoego exoego mentioned this pull request Mar 23, 2019
Merged
lubber-de
lubber-de requested changes Mar 23, 2019
View reviewed changes
Copy link
Member

@lubber-de lubber-de left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice PR.
I still have to test this more deeply, so only some cosmetic requests for now

src/definitions/modules/progress.js Outdated Show resolved Hide resolved
src/definitions/modules/progress.js Outdated Show resolved Hide resolved
@lubber-de lubber-de added type/feat Any feature requests or improvements lang/css Anything involving CSS lang/javascript Anything involving JavaScript tag/new-component New UI components state/awaiting-reviews Pull requests which are waiting for reviews labels Mar 23, 2019
@exoego exoego force-pushed the multi-progress branch 2 times, most recently from 580f86a to ebd2daa Compare March 23, 2019 14:29
@lubber-de lubber-de self-requested a review March 23, 2019 14:43
@lubber-de lubber-de self-requested a review March 23, 2019 14:43
lubber-de
lubber-de requested changes Mar 23, 2019
View reviewed changes
Copy link
Member

@lubber-de lubber-de left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good PR. Please take a look into my (sorry, lots of) comments

src/definitions/modules/progress.less Show resolved Hide resolved
src/definitions/modules/progress.less Show resolved Hide resolved
src/definitions/modules/progress.js Outdated Show resolved Hide resolved
src/definitions/modules/progress.js Outdated Show resolved Hide resolved
src/definitions/modules/progress.js Outdated Show resolved Hide resolved
src/definitions/modules/progress.js Outdated Show resolved Hide resolved
src/definitions/modules/progress.js Show resolved Hide resolved
src/definitions/modules/progress.js Outdated Show resolved Hide resolved
src/definitions/modules/progress.js Outdated Show resolved Hide resolved
src/definitions/modules/progress.js Outdated Show resolved Hide resolved
@lubber-de lubber-de added the state/awaiting-docs Pull requests which need doc changes/additions label Mar 23, 2019
@lubber-de lubber-de added the state/has-docs A issue/PR which requires documentation changes and has the corresponding PR open in the docs repo label Mar 24, 2019
@lubber-de lubber-de removed the state/awaiting-docs Pull requests which need doc changes/additions label Mar 24, 2019
lubber-de
lubber-de approved these changes Mar 24, 2019
View reviewed changes
Copy link
Member

@lubber-de lubber-de left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, awesome PR, thanks for your patience! 🙂

@lubber-de lubber-de added this to the 2.7.4 milestone Mar 24, 2019
y0hami
y0hami approved these changes Mar 24, 2019
View reviewed changes
Copy link
Member

@y0hami y0hami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@y0hami y0hami modified the milestones: 2.7.4, 2.7.3 Mar 26, 2019
prudho
prudho approved these changes Mar 26, 2019
View reviewed changes
Copy link
Contributor

@prudho prudho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice job @exoego !

@y0hami y0hami removed the state/awaiting-reviews Pull requests which are waiting for reviews label Mar 26, 2019
@y0hami y0hami merged commit c384e83 into fomantic:develop Mar 26, 2019
@exoego exoego deleted the multi-progress branch March 26, 2019 08:34
@crewow
Copy link

crewow commented Mar 27, 2019

its amazing

@y0hami y0hami mentioned this pull request Apr 1, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lubber-de lubber-de lubber-de approved these changes

@y0hami y0hami y0hami approved these changes

@prudho prudho prudho approved these changes

@ColinFrick ColinFrick Awaiting requested review from ColinFrick

Assignees
No one assigned
Labels
lang/css Anything involving CSS lang/javascript Anything involving JavaScript state/has-docs A issue/PR which requires documentation changes and has the corresponding PR open in the docs repo tag/new-component New UI components type/feat Any feature requests or improvements
Projects
None yet
Milestone
2.7.3
Development

Successfully merging this pull request may close these issues.
5 participants
@exoego @crewow @prudho @y0hami @lubber-de