Implement readFileSync for ZipTreeContainer #583
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gbockus-sf
commented
Feb 28, 2022
| v55 introduces the following new types. Here's their current level of support | ||
|
|
||
| |Metadata Type|Support|Notes| | ||
| |:---|:---|:---| |
There was a problem hiding this comment.
Not sure how this magic happens. commit flow I assume. Lemme know if I need to fix up something here.
gbockus-sf
commented
Feb 28, 2022
| "@salesforce/core": "^2.35.0", | ||
| "@salesforce/kit": "^1.5.32", | ||
| "@salesforce/ts-types": "^1.4.2", | ||
| "archiver": "^5.3.0", |
There was a problem hiding this comment.
This is the third party dependency that got the deal done. https://www.npmjs.com/package/deasync. MIT licensed and around 1M downloads a week so seemed a safe choice. I'm following up on what I need to do for 3PP land.
gbockus-sf
commented
Feb 28, 2022
| done = true; | ||
| throw error; | ||
| }); | ||
|
|
There was a problem hiding this comment.
This module covers doing exactly the ask here. Do something async but treat the current flow and synchronous.
jag-j
approved these changes
Mar 2, 2022
gbockus-sf
added a commit
that referenced
this pull request
Mar 11, 2022
This reverts commit da9c7ef.
gbockus-sf
added a commit
that referenced
this pull request
Mar 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Implements the readFileSync function in ZipTreeContainer.
I attempted to get this done without bringing in a third party module without success. Basically if TS/js wants to be sync/async there's no magic formula for getting around it. Also the zip module we are using
unzipperhas no support for reading a file synchronously.This PR brings in the deasync module that gets around this problem by providing a non-js solution for making an async flow synchronous.
What issues does this PR fix or reference?
Required for fixing @W-10120433@
Functionality Before
readFileSync was not implemented for ZipTreeContainer
Functionality After
readFileSync is implemented for ZipTreeContainer. Have verified that it fixes the issues found in https://github.com/forcedotcom/salesforcedx-vscode by linking the updated module locally.