revert commit that added deasync dependancy #591
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
istapletoncordascosfdc
approved these changes
Mar 11, 2022
mshanemc
approved these changes
Mar 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
revert the commit adding deasync. We ran into issues in vscode where on certain OSs it was unable to find a bindings.js file. We suspect it was specific to MacOS Monterey, but were unable to reproduce the issue
What issues does this PR fix or reference?
Related to forcedotcom/salesforcedx-vscode#3901. However we fixed the issue by setting the SDR version back to v5.12.2.
Functionality Before
Used deasync module to make readFileSync work for the ZipTreeContainer.
Functionality After
Back to throwing a no implemented error for readFileSync.