Skip to content

fix: allow larger directories to be compressed, test in plugin-source #649

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 16, 2022
Merged

fix: allow larger directories to be compressed, test in plugin-source #649

merged 2 commits into from
Jun 16, 2022

Conversation

WillieRuemmele
Copy link
Member

What does this PR do?

fixes archiver not finalizing larger directories in MdapiDeploy

What issues does this PR fix or reference?

@W-11209280@

Functionality Before

➜ sfdx force:mdapi:deploy -d src-converted -w 10

Functionality After

 ➜  ../../oss/plugin-source/bin/run force:mdapi:deploy -d src-converted -w 4
Deploy ID: 0AfJ000002FANRlKAP
*** Deploying with SOAP ***

@WillieRuemmele WillieRuemmele requested review from a team as code owners June 8, 2022 21:39
@WillieRuemmele WillieRuemmele requested a review from jeffb-sfdc June 8, 2022 21:39
@WillieRuemmele WillieRuemmele mentioned this pull request Jun 8, 2022
Closed
@WillieRuemmele WillieRuemmele mentioned this pull request Jun 16, 2022
Merged
@shetzel
Copy link
Contributor

shetzel commented Jun 16, 2022

I tested manually with 2000 apex classes and it failed without these changes but passed with them.

@shetzel shetzel merged commit ba713fb into main Jun 16, 2022
@shetzel shetzel deleted the wr/mdapiDeployNotDoingAnything branch June 16, 2022 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shetzel shetzel shetzel approved these changes

@jeffb-sfdc jeffb-sfdc Awaiting requested review from jeffb-sfdc jeffb-sfdc was automatically assigned from forcedotcom/ide-experience

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@WillieRuemmele @shetzel