Skip to content

fix: allow larger directories to be compressed, test in plugin-source #649

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 16, 2022
Merged

fix: allow larger directories to be compressed, test in plugin-source #649

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1eac718
fix: allow larger directories to be compressed, test in plugin-source
WillieRuemmele Jun 8, 2022
f43753f
Merge branch 'main' into wr/mdapiDeployNotDoingAnything
WillieRuemmele Jun 8, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/client/metadataApiDeploy.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -409,7 +409,7 @@ export class MetadataApiDeploy extends MetadataTransfer<MetadataApiDeployStatus,
const zip = createArchive('zip', { zlib: { level: 9 } });
// anywhere not at the root level is fine
zip.directory(this.options.mdapiPath, 'zip');
await zip.finalize();
void zip.finalize();
return stream2buffer(zip);
}
// read the zip into a buffer
Expand Down