Skip to content

Stijn goes typo hunting #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Oct 23, 2016
Merged

Stijn goes typo hunting #55

merged 10 commits into from
Oct 23, 2016

Conversation

StijnVrolijk
Copy link
Contributor

No description provided.

@StijnVrolijk StijnVrolijk changed the title [WIP] Stijn goes typo hunting Stijn goes typo hunting Oct 21, 2016
@StijnVrolijk StijnVrolijk force-pushed the stijn-goes-typo-hunting branch from 6381267 to b7c8d71 Compare October 21, 2016 12:14
Copy link
Member

@jessedobbelaere jessedobbelaere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@@ -41,7 +41,7 @@ url.rewrite-if-not-file = ( "^/?$" => "$0",
}
```

In this sample configuration, Fork CMS needs to rewrite its urls. This rewrite rule is based on the Apache .htaccess-file and should work with the latest lighttpd 1.4.x without causing a redirect loop.
In this sample configuration, Fork CMS needs to rewrite its urls. This rewrite rule is based on the Apache .htaccess-file and should work with the latest Lighttpd 1.4.x without causing a redirect loop.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Q: It's 2016. Does anyone still use Lighttpd or Cherokee? It's all apache or nginx in the world of webservers.
Maybe we should keep it simple and remove that part from the docs?

@jessedobbelaere jessedobbelaere merged commit 9533b2b into master Oct 23, 2016
@jessedobbelaere jessedobbelaere deleted the stijn-goes-typo-hunting branch October 23, 2016 00:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants