Skip to content

Test coverage fixes #667

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 18, 2025
Merged

Test coverage fixes #667

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ba255d6
valgrind: fully initialise INDEXBLOCK in NewDbase
jodavies Nov 12, 2024
ad7805e
valgrind: free allocated memory in GetDbase
jodavies Nov 12, 2024
6f794dc
fix: Transform islyndon+/- syntax, flip to match the manual
jodavies Jun 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions sources/minos.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -587,6 +587,8 @@ DBASE *GetDbase(char *filename, MLONG rwmode)
d->handle = f;
if ( ReadIniInfo(d) || ReadIndex(d) ) { M_free(d,"index-d"); fclose(f); return(0); }
if ( ComposeTableNames(d) < 0 ) { FreeTableBase(d); fclose(f); return(0); }
// free allocation from previous str_dup
M_free(d->name, "from str_dup");
d->name = str_dup(filename);
d->fullname = newname;
return(d);
Expand Down Expand Up @@ -676,6 +678,8 @@ DBASE *NewDbase(char *name,MLONG number)
if ( i > 0 ) d->iblocks[i]->previousblock = d->iblocks[i-1]->position;
else d->iblocks[i]->previousblock = -1;
d->iblocks[i]->position = ftell(f);
// Initialise, to keep valgrind happy
d->iblocks[i]->flags = -1;
/*----------change 10-feb-2003 */
/*
Zero things properly. We don't want garbage in the file.
Expand Down
10 changes: 5 additions & 5 deletions sources/transform.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,7 +163,7 @@ int CoTransform(UBYTE *in)
return(error);
}
in = SkipAName(in);
if ( *in == '>' || *in == '<' ) in++;
if ( *in == '>' || *in == '<' || *in == '+' || *in == '-' ) in++;
ss = in;
c = *ss; *ss = 0;
if ( c != '(' ) {
Expand Down Expand Up @@ -548,15 +548,15 @@ illsize: MesPrint("&Illegal value for base in encode/decode transformation")
type = ISLYNDON;
goto doreplace;
}
else if ( StrICmp(s,(UBYTE *)"islyndon+" ) == 0 ) {
else if ( StrICmp(s,(UBYTE *)"islyndon-" ) == 0 ) {
type = ISLYNDON;
goto doreplace;
}
else if ( StrICmp(s,(UBYTE *)"islyndon>" ) == 0 ) {
type = ISLYNDONR;
goto doreplace;
}
else if ( StrICmp(s,(UBYTE *)"islyndon-" ) == 0 ) {
else if ( StrICmp(s,(UBYTE *)"islyndon+" ) == 0 ) {
type = ISLYNDONR;
goto doreplace;
}
Expand All @@ -568,15 +568,15 @@ illsize: MesPrint("&Illegal value for base in encode/decode transformation")
type = TOLYNDON;
goto doreplace;
}
else if ( StrICmp(s,(UBYTE *)"tolyndon+" ) == 0 ) {
else if ( StrICmp(s,(UBYTE *)"tolyndon-" ) == 0 ) {
type = TOLYNDON;
goto doreplace;
}
else if ( StrICmp(s,(UBYTE *)"tolyndon>" ) == 0 ) {
type = TOLYNDONR;
goto doreplace;
}
else if ( StrICmp(s,(UBYTE *)"tolyndon-" ) == 0 ) {
else if ( StrICmp(s,(UBYTE *)"tolyndon+" ) == 0 ) {
type = TOLYNDONR;
goto doreplace;
}
Expand Down
Loading