adds check for negative discount amount and percent

Author: shreyanshdwivedi

app/api/schema/discount_codes.py

@@ -112,6 +112,11 @@ def validate_value(self, data, original_data):
                     {'pointer': '/data/attributes/value'},
                     "discount percent cannot be more than 100%"
                 )
+            if data['value'] < 0:
+                raise UnprocessableEntity(
+                    {'pointer': '/data/attributes/value'},
+                    "discount percent cannot be less than 0%"
+                )
 
         if data['type'] == "amount":
             event_object = Event.query.filter_by(id=data['event']).one()
@@ -121,6 +126,11 @@ def validate_value(self, data, original_data):
                         {'pointer': '/data/attributes/value'},
                         "discount amount cannot be more than ticket amount"
                     )
+            if data['value'] < 0:
+                raise UnprocessableEntity(
+                    {'pointer': '/data/attributes/value'},
+                    "discount amount cannot be less than zero"
+                )
 
     @validates_schema(pass_original=True)
     def validate_date(self, data, original_data):
@@ -205,6 +215,11 @@ def validate_value(self, data, original_data):
                     {'pointer': '/data/attributes/value'},
                     "discount percent cannot be more than 100%"
                 )
+            if data['value'] < 0:
+                raise UnprocessableEntity(
+                    {'pointer': '/data/attributes/value'},
+                    "discount percent cannot be less than 0%"
+                )
 
         if data['type'] == "amount":
             for ticket in data['tickets']:
@@ -214,6 +229,11 @@ def validate_value(self, data, original_data):
                         {'pointer': '/data/attributes/value'},
                         "discount amount cannot be more than ticket amount"
                     )
+            if data['value'] < 0:
+                raise UnprocessableEntity(
+                    {'pointer': '/data/attributes/value'},
+                    "discount amount cannot be less than zero"
+                )
 
     @validates_schema(pass_original=True)
     def validate_date(self, data, original_data):