Skip to content

Addresses #468 Added bing news search #489

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 1, 2018
Merged

Conversation

Remorax
Copy link
Contributor

@Remorax Remorax commented Jan 31, 2018

Addresses #468

Checklist

  • I have read the Contribution & Best practices Guide and my PR follows them.
  • My branch is up-to-date with the Upstream master branch.
  • I have added necessary documentation (if appropriate)

Changes proposed in this pull request:

Link: https://evening-eyrie-95749.herokuapp.com/

@vaibhavsingh97 @ParthS007 @realslimshanky Please review 😄

@codecov
Copy link

codecov bot commented Jan 31, 2018

Codecov Report

Merging #489 into master will increase coverage by 8.36%.
The diff coverage is 90.32%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #489      +/-   ##
==========================================
+ Coverage   82.54%   90.91%   +8.36%     
==========================================
  Files          29       29              
  Lines         957      881      -76     
==========================================
+ Hits          790      801      +11     
+ Misses        167       80      -87
Impacted Files Coverage Δ
app/scrapers/__init__.py 96% <ø> (+13.14%) ⬆️
app/scrapers/bing.py 100% <100%> (ø) ⬆️
test/test_bing.py 100% <100%> (ø) ⬆️
app/scrapers/generalized.py 87.09% <72.72%> (+48.74%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cf912cc...ff99c34. Read the comment docs.

Copy link
Member

@ParthS007 ParthS007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ! Please squash your commits 👍

@Remorax
Copy link
Contributor Author

Remorax commented Feb 1, 2018

@ParthS007 I've resolved the merge conflicts but I did it using the GUI so can the latest commit be merged?

Copy link
Member

@bhaveshAn bhaveshAn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked links, few notes:
Search for google keyword in Bing for General search and News. Same response.

[
    {
        "desc": "Search the world's information, including webpages, images, videos and more. Google has many special features to help you find exactly what you're looking for.",
        "link": "http://www.google.com/",
        "title": "Google"
    },
    {
        "desc": "Google, Mountain View, CA. 25M likes. Organizing the world's information and making it universally accessible and useful.",
        "link": "https://www.facebook.com/Google",
        "title": "Google - Home | Facebook"
    },
    {
        "desc": "Google teamed up with Xprize to sponsor an audacious literal race to the Moon, but sadly the competition will end with no one taking home the grand prize of $30 ...",
        "link": "https://finance.yahoo.com/quote/googl/",
        "title": "GOOGL : Summary for Alphabet Inc. - Yahoo Finance"
    },
    {
        "desc": "Google LLC is an American multinational technology company that specializes in Internet-related services and products, which include online advertising ...",
        "link": "https://en.wikipedia.org/wiki/Google",
        "title": "Google - Wikipedia"
    },
    {
        "desc": "Discover all the latest about our products, technology, and Google culture on our official blog.",
        "link": "https://www.blog.google/",
        "title": "The Keyword | Google"
    },
    {
        "desc": "Data-driven, human-focused philanthropy— powered by Google We bring the best of Google to innovative nonprofits that are committed to creating a world that works ...",
        "link": "https://www.google.org/",
        "title": "Home – Google.org"
    },

@Remorax
Copy link
Contributor Author

Remorax commented Feb 1, 2018

@bhaveshAn The link has been updated. Please check now.

@bhaveshAn
Copy link
Member

I mean response is same whether I go for General search or News search.
Just search for any keyword for General search and News search. You will get the same results.
Go through these get requests and see the differences, if any. (No difference)
General search : https://infinite-scrubland-15160.herokuapp.com/api/v1/search/bing?query=google&qtype=general&format=json
News search : https://infinite-scrubland-15160.herokuapp.com/api/v1/search/bing?query=google&qtype=news&format=json

@bhaveshAn bhaveshAn merged commit f517880 into fossasia:master Feb 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants