Fixes #358 Allow user to specify branch to generate docs #424
Conversation
imujjwal96
force-pushed
the
issue358
branch
4 times, most recently
from
95213c8 to
b611aeb
Compare
|
@pri22296 @Sch00lb0y Please review. |
| @@ -1,10 +1,9 @@ | |||
| $(function() { | |||
| const predefinedMessages = { | |||
| 'mail_disabled_successful': "Mail service disabled for this repository", | |||
There was a problem hiding this comment.
Are these messages no longer needed?
There was a problem hiding this comment.
No we are not showing them now. We have added a toggle for these events and we show a check mark beside the element when the change is successful
|
@imujjwal96 Shows null after adding and deleting branches
|
|
@pri22296 I am not able to reproduce this error |
|
@imujjwal96 Let me test this more and i'll get back to you If I can reproduce it. |
|
@imujjwal96 I'm not able to reproduce that error. It wold be great though if you could take a look at the code and just ensure that everything is fine. Also submit button gets hidden when there are >=3 branches. |
|
|
The UI feels awkward there. consider showing the branches with a scroll bar and having the submit button slightly below. |
|
@pri22296 Updated it. |
ghost
removed
the
backend/github.js
Outdated
| }, function (error, response, body) { | ||
| if (error) { | ||
| callback(error); |
There was a problem hiding this comment.
pass null in the second parameter. it look consistent
|
@pri22296 @Sch00lb0y Updated |
Description
Allow users to specify branches from their registered repositories settings at Yaydoc. User may also delete some of the specified branches.
If no branches are specified, documentation will be generated from all branches containing
.yaydoc.ymlfile, except the gh-pages branchRelated Issue
Fixes #358
Motivation and Context
The documentation for a registered repository is generated at every commit made to the repository. This process happens in commits made to any of the repository's branches except for branches that do not have a .yaydoc.yml file and the gh-pages branch. It would be nice if the user can limit the doc generation process to a specific branch or a couple of branches
How Has This Been Tested?
Test at https://yaydoc7.herokuapp.com
Types of changes
Checklist:
Fixes #<number> commit message