feat(api): Get all standard comments #2517
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dushimsam
force-pushed
the
get-all-license-std-comments
branch
from
9d61777
to
b9cb32c
Compare
dushimsam
changed the title
dushimsam
force-pushed
the
get-all-license-std-comments
branch
from
b9cb32c
to
dd6aa90
Compare
GMishx
added
needs code review
needs test
GSOC-23
|
This pull request has conflicts, please rebase with master to resolve those before we can evaluate the pull request. |
GMishx
requested changes
Jul 31, 2023
|
Tested, working as expected. |
dushimsam
force-pushed
the
get-all-license-std-comments
branch
from
dd6aa90
to
8e37a4f
Compare
|
@dushimsam , please rebase for merge. |
|
This pull request has conflicts, please rebase with master to resolve those before we can evaluate the pull request. |
Signed-off-by: dushimsam <dushsam@gmail.com>
dushimsam
force-pushed
the
get-all-license-std-comments
branch
from
8e37a4f
to
a95d774
Compare
|
Done |
GMishx
added a commit
to siemens/fossology
that referenced
this pull request
Sep 29, 2023
Update API version after merge of: fossology#2483 fossology#2517 fossology#2518 fossology#2524 fossology#2528 fossology#2529 fossology#2530 fossology#2532 fossology#2533 fossology#2534 fossology#2535 fossology#2536 fossology#2537 fossology#2538 fossology#2539 fossology#2545 fossology#2549 fossology#2576 Signed-off-by: Gaurav Mishra <mishra.gaurav@siemens.com>
Ibrahim-Muhammad13
pushed a commit
to Ibrahim-Muhammad13/fossology
that referenced
this pull request
Feb 20, 2024
Update API version after merge of: fossology#2483 fossology#2517 fossology#2518 fossology#2524 fossology#2528 fossology#2529 fossology#2530 fossology#2532 fossology#2533 fossology#2534 fossology#2535 fossology#2536 fossology#2537 fossology#2538 fossology#2539 fossology#2545 fossology#2549 fossology#2576 Signed-off-by: Gaurav Mishra <mishra.gaurav@siemens.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added the API to retrieve a list of the standard comments.
Changes
LicenseControllerto build the functionality.index.php) by adding a new routeGET/licenses/stdcomments.openapi.yamlfile to write the new API's documentation.How to test
Make a GET request on the endpoint:
/licenses/stdcomments,Screenshots
Related Issue:
Fixes #2511
cc: @shaheemazmalmmd @GMishx