Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(api): Get PHP-Info for the Dasbhoard Overview #2535

Merged
merged 1 commit into from
Sep 26, 2023

Conversation

dushimsam
Copy link
Contributor

@dushimsam dushimsam commented Jul 9, 2023

Description

Added the API to retrieve the PHP-Info for the Admin Dashboard overview.

Changes

  1. Added a new method in OverviewController to build the functionality.
  2. Updated the main file(index.php) by adding a new route GET /overview/info/php.
  3. Updated the openapi.yaml file to write the new API's documentation.

How to test

Make a GET request on the endpoint: /overview/info/php,

Screenshots

image
image

Related Issue:

Fixes #2523

cc: @shaheemazmalmmd @GMishx

@GMishx GMishx added needs code review needs test GSOC-23 Label to tag pull request which are part of the GSOC 2023 labels Jul 10, 2023
@github-actions github-actions bot added the has merge conflicts PR to be rebased label Jul 26, 2023
@github-actions
Copy link

This pull request has conflicts, please rebase with master to resolve those before we can evaluate the pull request.

Copy link
Member

@GMishx GMishx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good.

Copy link
Member

@GMishx GMishx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, working as expected.

@github-actions
Copy link

github-actions bot commented Sep 5, 2023

This pull request has conflicts, please rebase with master to resolve those before we can evaluate the pull request.

@github-actions
Copy link

This pull request has conflicts, please rebase with master to resolve those before we can evaluate the pull request.

Signed-off-by: dushimsam <dushsam@gmail.com>
@github-actions github-actions bot removed the has merge conflicts PR to be rebased label Sep 26, 2023
@GMishx GMishx merged commit 1221884 into fossology:master Sep 26, 2023
13 checks passed
@GMishx GMishx deleted the get-php-info branch September 26, 2023 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GSOC-23 Label to tag pull request which are part of the GSOC 2023 ready
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dashboard
2 participants