Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(api): Get database metrics overview for dashboard #2532

Merged
merged 1 commit into from
Sep 27, 2023

Conversation

dushimsam
Copy link
Contributor

@dushimsam dushimsam commented Jul 7, 2023

Description

Added the API to retrieve the database metrics with corresponding statuses.

Changes

  1. Added a new method in OverviewController to build the functionality.
  2. Updated the main file(index.php) by adding a new route GET /overview/database/metrics.
  3. Updated the openapi.yaml file to write the new API's documentation.

How to test

Make a GET request on the endpoint: /overview/database/metrics,

Screenshots

image
image

Related Issue:

Fixes #2523

cc: @shaheemazmalmmd @GMishx

@GMishx GMishx added needs code review needs test GSOC-23 Label to tag pull request which are part of the GSOC 2023 labels Jul 10, 2023
@github-actions github-actions bot added the has merge conflicts PR to be rebased label Jul 26, 2023
@github-actions
Copy link

This pull request has conflicts, please rebase with master to resolve those before we can evaluate the pull request.

src/www/ui/admin-dashboard-general.php Outdated Show resolved Hide resolved
src/www/ui/admin-dashboard-general.php Outdated Show resolved Hide resolved
src/www/ui/api/Controllers/OverviewController.php Outdated Show resolved Hide resolved
@github-actions github-actions bot removed the has merge conflicts PR to be rebased label Aug 14, 2023
@dushimsam dushimsam force-pushed the get-database-metrics branch 2 times, most recently from 2ed6c6c to bb64d08 Compare August 22, 2023 15:41
@dushimsam
Copy link
Contributor Author

Done @GMishx

Copy link
Member

@GMishx GMishx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes looks good.

src/www/ui/admin-dashboard-general.php Outdated Show resolved Hide resolved
@GMishx GMishx added the has merge conflicts PR to be rebased label Aug 28, 2023
@github-actions github-actions bot removed the has merge conflicts PR to be rebased label Aug 28, 2023
src/www/ui/api/documentation/openapi.yaml Outdated Show resolved Hide resolved
@github-actions github-actions bot added the has merge conflicts PR to be rebased label Aug 30, 2023
@github-actions
Copy link

This pull request has conflicts, please rebase with master to resolve those before we can evaluate the pull request.

@github-actions github-actions bot added has merge conflicts PR to be rebased and removed has merge conflicts PR to be rebased labels Aug 31, 2023
@github-actions
Copy link

github-actions bot commented Sep 5, 2023

This pull request has conflicts, please rebase with master to resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the has merge conflicts PR to be rebased label Sep 12, 2023
@github-actions github-actions bot added the has merge conflicts PR to be rebased label Sep 26, 2023
@github-actions
Copy link

This pull request has conflicts, please rebase with master to resolve those before we can evaluate the pull request.

Copy link
Member

@GMishx GMishx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, working as expected.

@GMishx GMishx removed the needs test label Sep 27, 2023
@GMishx GMishx added the ready label Sep 27, 2023
Signed-off-by: dushimsam <dushsam@gmail.com>
@github-actions github-actions bot removed the has merge conflicts PR to be rebased label Sep 27, 2023
@GMishx GMishx merged commit b6dcafb into fossology:master Sep 27, 2023
13 checks passed
@GMishx GMishx deleted the get-database-metrics branch September 27, 2023 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GSOC-23 Label to tag pull request which are part of the GSOC 2023 ready
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dashboard
2 participants