-
Notifications
You must be signed in to change notification settings - Fork 399
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(api): verify license as new or variant #2528
Conversation
This pull request has conflicts, please rebase with master to resolve those before we can evaluate the pull request. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A minor change needed.
936d12f
to
c06e5d5
Compare
c06e5d5
to
fae79a8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes looks good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested, working as expected.
fae79a8
to
bc40f7e
Compare
@dushimsam can you please rebase the branch so we can merge? Alternatively, requesting you to provide me access to your fork so I can rebase the branches for you. |
Sorry @GMishx, let me rebase all the branches. Thank you |
Signed-off-by: dushimsam <dushsam@gmail.com>
bc40f7e
to
7e7e0eb
Compare
Update API version after merge of: fossology#2483 fossology#2517 fossology#2518 fossology#2524 fossology#2528 fossology#2529 fossology#2530 fossology#2532 fossology#2533 fossology#2534 fossology#2535 fossology#2536 fossology#2537 fossology#2538 fossology#2539 fossology#2545 fossology#2549 fossology#2576 Signed-off-by: Gaurav Mishra <mishra.gaurav@siemens.com>
Update API version after merge of: fossology#2483 fossology#2517 fossology#2518 fossology#2524 fossology#2528 fossology#2529 fossology#2530 fossology#2532 fossology#2533 fossology#2534 fossology#2535 fossology#2536 fossology#2537 fossology#2538 fossology#2539 fossology#2545 fossology#2549 fossology#2576 Signed-off-by: Gaurav Mishra <mishra.gaurav@siemens.com>
Description
Added the API to verify a given a license as new one or the variant of another existing license.
Changes
LicenseController
to build the functionality.index.php
) by adding a new routePUT
/license/verify/{shortname}
.openapi.yaml
file to write the new API's documentation.How to test
Make a PUT request on the endpoint:
/license/verify/{shortname}
,Screenshots
1. Verify as new (
shortname in args and body are expected to match
)2. Verify as a variant
Related Issue:
Fixes #2510
cc: @shaheemazmalmmd @GMishx