-
Notifications
You must be signed in to change notification settings - Fork 399
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(SETUP-V2): Support Multiple Versions (V1 & V2) #2576
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dushimsam
force-pushed
the
set-up-v2
branch
3 times, most recently
from
August 23, 2023 13:04
df5458e
to
d63e69e
Compare
GMishx
added
needs code review
needs test
GSOC-23
Label to tag pull request which are part of the GSOC 2023
labels
Aug 24, 2023
GMishx
requested changes
Aug 24, 2023
Signed-off-by: dushimsam <dushsam@gmail.com>
GMishx
approved these changes
Aug 24, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes looks good. Needs test.
GMishx
approved these changes
Aug 28, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested, working as expected.
GMishx
added a commit
to siemens/fossology
that referenced
this pull request
Sep 29, 2023
Update API version after merge of: fossology#2483 fossology#2517 fossology#2518 fossology#2524 fossology#2528 fossology#2529 fossology#2530 fossology#2532 fossology#2533 fossology#2534 fossology#2535 fossology#2536 fossology#2537 fossology#2538 fossology#2539 fossology#2545 fossology#2549 fossology#2576 Signed-off-by: Gaurav Mishra <mishra.gaurav@siemens.com>
Ibrahim-Muhammad13
pushed a commit
to Ibrahim-Muhammad13/fossology
that referenced
this pull request
Feb 20, 2024
Update API version after merge of: fossology#2483 fossology#2517 fossology#2518 fossology#2524 fossology#2528 fossology#2529 fossology#2530 fossology#2532 fossology#2533 fossology#2534 fossology#2535 fossology#2536 fossology#2537 fossology#2538 fossology#2539 fossology#2545 fossology#2549 fossology#2576 Signed-off-by: Gaurav Mishra <mishra.gaurav@siemens.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request (PR) focuses on enhancing the functionality of the API configuration to accommodate the routes of Version 2.
Changes
1. Dynamic Base URL Support:
The i
index.php
file has been revised to facilitate the dynamic base URL, capable of accommodating both V1 and V2 versions of the API.2. OpenAPI Specification Update:
The
openapi.yml
file has been updated to incorporate the server URL specific to Version 2 of the API.How to test
1. Add this block of code in the
getInfo
method fromInfoController
:2. Call the Version 1 API
3. Call the Version 2 API
4. Other Cases
Related Issue:
Fixes #2575
cc: @shaheemazmalmmd @GMishx