headers(part2) - feat: add Downloader trait and test utils #118
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #118 +/- ##
==========================================
+ Coverage 69.49% 70.66% +1.16%
==========================================
Files 130 135 +5
Lines 8776 9186 +410
==========================================
+ Hits 6099 6491 +392
- Misses 2677 2695 +18
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
gakonst
changed the title
gakonst
force-pushed
the
gakonst/downloader-test-utils
branch
from
bd27baf to
c19a425
Compare
rkrasiuk
approved these changes
Oct 24, 2022
mattsse
approved these changes
Oct 24, 2022
crates/interfaces/src/lib.rs
Outdated
Comment on lines
29
to
31
| #[cfg(any(test, feature = "test-helpers"))] | ||
| /// Common test helpers for mocking out Consensus, Downloaders and Header Clients. | ||
| pub mod test_helpers { |
Collaborator
There was a problem hiding this comment.
should we move this to a separate file?
* feat: add headers downloaders crate * feat: more scaffolding * interfaces: generalize retryable erros * feat: implement linear downloader * fix linear downloader tests & add builder * extend & reverse * feat: linear downloader generics behind arc and reversed return order (#120) * put client & consensus behind arc and return headers in rev * cleanup Co-authored-by: Roman Krasiuk <rokrassyuk@gmail.com>
rkrasiuk
added
C-enhancement
yutianwu
pushed a commit
to yutianwu/reth
that referenced
this pull request
Sep 6, 2024
release: prepare for release v1.0.2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on #117 and part of splitting #58 in parts which can be individually reviewed.
Downloadertrait tointerfacesinterfaces::test_utilswhich implementsTestConsensus,TestHeadersClientand `TestFollow up: add a
net/downloaderscrate which contains thelineardownloader from #58.--
@rakita I think we'll soon want the rest of the impls here: https://github.com/foundry-rs/reth/blob/2e6b18a1547ef01bf30a5141a29ec8ffe081f331/crates/interfaces/src/db/mock.rs#L42-L180, so we can run the Stages w/o using MDBX at all