Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Frappe UI Dialog stays above dom freeze screen #20538

Closed
Jainysh opened this issue Mar 31, 2023 · 3 comments · Fixed by #20541
Closed

Frappe UI Dialog stays above dom freeze screen #20538

Jainysh opened this issue Mar 31, 2023 · 3 comments · Fixed by #20541
Labels
bug released

Comments

@Jainysh
Copy link
Contributor

Jainysh commented Mar 31, 2023

Description of the issue

When a frappe dialog is open and if a frappe.dom.freeze("My Message") is used to prevent the user from performing an action on dialog, the dialog stays above the freeze component and the user can still perform actions on the dialog while freeze screen is still active.

Context information (for bug reports)

This happens as z-index of dialog is more than the freeze component z-index.

Output of bench version

erpnext 14.x.x-develop
frappe 15.x.x-develop
india_compliance 14.0.0
payments 0.0.1

Steps to reproduce the issue

  1. Open a dialog using frappe.ui.dialog or any existing dialog
  2. Trigger frappe.dom.freeze("Some message here") in browser console.
  3. This generates a freeze screen beneath the dialog box.

Observed result

  • Freeze screen stays below the dialog box and hence user can perform any action on dialog box (like submitting the form again or closing it while the API call isn't finished yet)

Expected result

  • The freeze screen should be above the dialog box and user should not be allowed to interact with dialog when freeze is still active.

Additional information

  • Attached screen recording. In atached video, user can interact with dialog even when screen is frozen.
Screen.Recording.2023-03-31.at.6.23.05.PM.mov
@Jainysh Jainysh added the bug label Mar 31, 2023
@Jainysh
Copy link
Contributor Author

Jainysh commented Mar 31, 2023

@surajshetty3416 The quick fix for this is updating the z-index to 9999 from 1020 in #freeze css id in apps/frappe/frappe/public/scss/desk/global.scss file.

Jainysh added a commit to Jainysh/frappe that referenced this issue Mar 31, 2023
@Jainysh
fix: change z-index of freeze component to make it appear above all c…
96395d6 
…omponents

changed the z-index value of #freeze id to 9999 so that it appears above all UI components

fixes frappe#20538
@Jainysh Jainysh mentioned this issue Mar 31, 2023
Merged
This was referenced Apr 5, 2023
Closed
Closed
mergify bot pushed a commit that referenced this issue Apr 10, 2023
@Jainysh @mergify
fix: change z-index of freeze component to make it appear above all c…
f6ebae9 
…omponents

changed the z-index value of #freeze id to 9999 so that it appears above all UI components

fixes #20538

(cherry picked from commit 96395d6)
mergify bot pushed a commit that referenced this issue Apr 10, 2023
@Jainysh @mergify
fix: change z-index of freeze component to make it appear above all c…
1878b87 
…omponents

changed the z-index value of #freeze id to 9999 so that it appears above all UI components

fixes #20538

(cherry picked from commit 96395d6)
frappe-pr-bot pushed a commit that referenced this issue Apr 11, 2023
@frappe-bot
chore(release): Bumped to Version 14.32.0
be4c28e 
# [14.32.0](v14.31.0...v14.32.0) (2023-04-11)

### Bug Fixes

* also build jsx files ([#20624](#20624)) ([#20628](#20628)) ([01f4c38](01f4c38))
* better permission error for query_report ([#20643](#20643)) ([#20647](#20647)) ([33be129](33be129))
* change z-index of freeze component to make it appear above all components ([f6ebae9](f6ebae9)), closes [#20538](#20538)
* child row form should be above freeze screen ([8d4402e](8d4402e))
* Consider global default in user perm ([87e1aee](87e1aee))
* Consider user perimission default in get_user_default function ([24f6931](24f6931))
* dont create communication for auto repeat notification ([#20606](#20606)) ([#20611](#20611)) ([e9fc2ae](e9fc2ae))
* german translation of workflow state ([#20609](#20609)) ([#20616](#20616)) ([4d7a080](4d7a080))
* **grid row:** fix prettier hook check ([583e1d4](583e1d4))
* **grid row:** fix update_docfield_property function not updating grid row ([a2e9cc0](a2e9cc0))
* improved validation in `add_comment` ([#20520](#20520)) ([4d920fa](4d920fa))
* **ListView:** Evaluate sort_field sort_order within listviews based on DocTypes Definition ([#20482](#20482)) ([b560ccd](b560ccd))
* log requests even if no response ([#20638](#20638)) ([#20640](#20640)) ([a43c11e](a43c11e))
* minor oauth doctypes enhancements ([#20613](#20613)) ([75300f7](75300f7))
* **pretty-date:** plural form when the value is 1 ([#20619](#20619)) ([#20642](#20642)) ([7f6a557](7f6a557))
* track workspace changes ([#20649](#20649)) ([#20650](#20650)) ([5f54325](5f54325))
* validate if doctype exists before syncing customisations (backport [#20598](#20598)) ([#20645](#20645)) ([9a39bf8](9a39bf8))

### Features

* make report name translatable ([#20608](#20608)) ([#20618](#20618)) ([ed49e83](ed49e83))

### Performance Improvements

* Don't re-initate sessions in realtime.py ([#20577](#20577)) ([7480b86](7480b86))
@frappe-pr-bot
Copy link
Collaborator

🎉 This issue has been resolved in version 14.32.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

frappe-pr-bot pushed a commit that referenced this issue Apr 11, 2023
@frappe-bot
chore(release): Bumped to Version 13.53.0
809f58e 
# [13.53.0](v13.52.0...v13.53.0) (2023-04-11)

### Bug Fixes

* allow `reset_otp_secret` only if Two Factor Auth is enabled (backport [#20506](#20506)) ([#20560](#20560)) ([e8025a4](e8025a4))
* better permission error for query_report ([#20643](#20643)) ([#20646](#20646)) ([d972af8](d972af8))
* change z-index of freeze component to make it appear above all components ([1878b87](1878b87)), closes [#20538](#20538)
* child row form should be above freeze screen ([9201e84](9201e84))
* client script add to instead of replace ([0c7ac16](0c7ac16))
* client_script default value ([9ed7851](9ed7851))
* german translation of workflow state ([#20609](#20609)) ([#20615](#20615)) ([3769bdf](3769bdf))
* **grid row:** fix prettier hook check ([9309687](9309687))
* **grid row:** fix update_docfield_property function not updating grid row ([558f908](558f908))
* **ListView:** Evaluate sort_field sort_order within listviews based on DocTypes Definition ([#20482](#20482)) ([ba3cf84](ba3cf84))
* log requests even if no response ([#20638](#20638)) ([#20639](#20639)) ([ae4f7dd](ae4f7dd))
* no optional chaining in v13 ([d08627b](d08627b))
* **pretty-date:** plural form when the value is 1 ([#20619](#20619)) ([#20641](#20641)) ([4d6b776](4d6b776))
* validate if doctype exists before syncing customisations ([#20598](#20598)) ([#20644](#20644)) ([32ba65f](32ba65f))

### Features

* add context to confirm dailog ([0e21299](0e21299))
* add context to prompt dialog ([1bbf9c9](1bbf9c9))
* make report name translatable (backport [#20608](#20608)) ([#20617](#20617)) ([a92e69e](a92e69e))
* **minor:** log datetime in worker log (backport [#20414](#20414)) ([#20569](#20569)) ([dccb6af](dccb6af))
@frappe-pr-bot
Copy link
Collaborator

🎉 This issue has been resolved in version 13.53.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: change z-index of freeze component Jainysh/frappe
2 participants
@Jainysh @frappe-pr-bot