fix: validate if doctype exists before syncing customisations #20598
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saurabh6790
requested review from
a team and
phot0n
and removed request for
a team
github-actions
bot
added
the
add-test-cases
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #20598 +/- ##
===========================================
- Coverage 63.75% 63.74% -0.01%
===========================================
Files 758 758
Lines 68709 68918 +209
Branches 6196 6196
===========================================
+ Hits 43803 43934 +131
- Misses 21269 21347 +78
Partials 3637 3637
Flags with carried forward coverage won't be shown. Click here to find out more. |
saurabh6790
requested review from
surajshetty3416
and removed request for
phot0n
ankush
changed the title
|
@saurabh6790 any change to production code should not be |
ankush
requested changes
Apr 6, 2023
saurabh6790
force-pushed
the
validate_doctype
branch
from
6e0d70b
to
3713b52
Compare
saurabh6790
force-pushed
the
validate_doctype
branch
from
3713b52
to
8a3f058
Compare
|
@ankush pushed a fix |
ankush
added
Skip CI
mergify bot
pushed a commit
that referenced
this pull request
Apr 11, 2023
* fix: validate if doctype exists before syncing customisations * refactor: rename and add default --------- Co-authored-by: Ankush Menat <ankush@frappe.io> (cherry picked from commit 26e7320) # Conflicts: # frappe/modules/utils.py
This was referenced Apr 11, 2023
ankush
pushed a commit
that referenced
this pull request
Apr 11, 2023
* fix: validate if doctype exists before syncing customisations * refactor: rename and add default --------- Co-authored-by: Ankush Menat <ankush@frappe.io> (cherry picked from commit 26e7320)
ankush
added a commit
that referenced
this pull request
Apr 11, 2023
#20598) (#20645) * fix: validate if doctype exists before syncing customisations (#20598) * fix: validate if doctype exists before syncing customisations * refactor: rename and add default --------- Co-authored-by: Ankush Menat <ankush@frappe.io> (cherry picked from commit 26e7320) # Conflicts: # frappe/modules/utils.py * chore: conflicts --------- Co-authored-by: Saurabh <saurabh6790@gmail.com> Co-authored-by: Ankush Menat <ankush@frappe.io>
frappe-pr-bot
pushed a commit
that referenced
this pull request
Apr 11, 2023
# [14.32.0](v14.31.0...v14.32.0) (2023-04-11) ### Bug Fixes * also build jsx files ([#20624](#20624)) ([#20628](#20628)) ([01f4c38](01f4c38)) * better permission error for query_report ([#20643](#20643)) ([#20647](#20647)) ([33be129](33be129)) * change z-index of freeze component to make it appear above all components ([f6ebae9](f6ebae9)), closes [#20538](#20538) * child row form should be above freeze screen ([8d4402e](8d4402e)) * Consider global default in user perm ([87e1aee](87e1aee)) * Consider user perimission default in get_user_default function ([24f6931](24f6931)) * dont create communication for auto repeat notification ([#20606](#20606)) ([#20611](#20611)) ([e9fc2ae](e9fc2ae)) * german translation of workflow state ([#20609](#20609)) ([#20616](#20616)) ([4d7a080](4d7a080)) * **grid row:** fix prettier hook check ([583e1d4](583e1d4)) * **grid row:** fix update_docfield_property function not updating grid row ([a2e9cc0](a2e9cc0)) * improved validation in `add_comment` ([#20520](#20520)) ([4d920fa](4d920fa)) * **ListView:** Evaluate sort_field sort_order within listviews based on DocTypes Definition ([#20482](#20482)) ([b560ccd](b560ccd)) * log requests even if no response ([#20638](#20638)) ([#20640](#20640)) ([a43c11e](a43c11e)) * minor oauth doctypes enhancements ([#20613](#20613)) ([75300f7](75300f7)) * **pretty-date:** plural form when the value is 1 ([#20619](#20619)) ([#20642](#20642)) ([7f6a557](7f6a557)) * track workspace changes ([#20649](#20649)) ([#20650](#20650)) ([5f54325](5f54325)) * validate if doctype exists before syncing customisations (backport [#20598](#20598)) ([#20645](#20645)) ([9a39bf8](9a39bf8)) ### Features * make report name translatable ([#20608](#20608)) ([#20618](#20618)) ([ed49e83](ed49e83)) ### Performance Improvements * Don't re-initate sessions in realtime.py ([#20577](#20577)) ([7480b86](7480b86))
frappe-pr-bot
pushed a commit
that referenced
this pull request
Apr 11, 2023
# [13.53.0](v13.52.0...v13.53.0) (2023-04-11) ### Bug Fixes * allow `reset_otp_secret` only if Two Factor Auth is enabled (backport [#20506](#20506)) ([#20560](#20560)) ([e8025a4](e8025a4)) * better permission error for query_report ([#20643](#20643)) ([#20646](#20646)) ([d972af8](d972af8)) * change z-index of freeze component to make it appear above all components ([1878b87](1878b87)), closes [#20538](#20538) * child row form should be above freeze screen ([9201e84](9201e84)) * client script add to instead of replace ([0c7ac16](0c7ac16)) * client_script default value ([9ed7851](9ed7851)) * german translation of workflow state ([#20609](#20609)) ([#20615](#20615)) ([3769bdf](3769bdf)) * **grid row:** fix prettier hook check ([9309687](9309687)) * **grid row:** fix update_docfield_property function not updating grid row ([558f908](558f908)) * **ListView:** Evaluate sort_field sort_order within listviews based on DocTypes Definition ([#20482](#20482)) ([ba3cf84](ba3cf84)) * log requests even if no response ([#20638](#20638)) ([#20639](#20639)) ([ae4f7dd](ae4f7dd)) * no optional chaining in v13 ([d08627b](d08627b)) * **pretty-date:** plural form when the value is 1 ([#20619](#20619)) ([#20641](#20641)) ([4d6b776](4d6b776)) * validate if doctype exists before syncing customisations ([#20598](#20598)) ([#20644](#20644)) ([32ba65f](32ba65f)) ### Features * add context to confirm dailog ([0e21299](0e21299)) * add context to prompt dialog ([1bbf9c9](1bbf9c9)) * make report name translatable (backport [#20608](#20608)) ([#20617](#20617)) ([a92e69e](a92e69e)) * **minor:** log datetime in worker log (backport [#20414](#20414)) ([#20569](#20569)) ([dccb6af](dccb6af))
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before Fix
After fix