fix(ListView): Evaluate sort_field sort_order within listviews based on DocTypes Definition #20482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BaseList will fetch the sort_field and sort_order based on DocType Definition/ Customize Form Definition
pstuhlmueller
requested review from
a team and
phot0n
and removed request for
a team
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed within 3 days if no further activity occurs, but it only takes a comment to keep a contribution alive :) Also, even if it is closed, you can always reopen the PR when you're ready. Thank you for contributing. |
|
Ideally we can merge this PR, as this fixes a multiple year old issue regarding sorting capabilities. |
shariquerik
approved these changes
Apr 10, 2023
shariquerik
added
backport version-13-hotfix
backport version-14-hotfix
shariquerik
added a commit
that referenced
this pull request
Apr 10, 2023
…-20482 fix(ListView): Evaluate sort_field sort_order within listviews based on DocTypes Definition (backport #20482)
shariquerik
added a commit
that referenced
this pull request
Apr 10, 2023
…-20482 fix(ListView): Evaluate sort_field sort_order within listviews based on DocTypes Definition (backport #20482)
frappe-pr-bot
pushed a commit
that referenced
this pull request
Apr 11, 2023
# [14.32.0](v14.31.0...v14.32.0) (2023-04-11) ### Bug Fixes * also build jsx files ([#20624](#20624)) ([#20628](#20628)) ([01f4c38](01f4c38)) * better permission error for query_report ([#20643](#20643)) ([#20647](#20647)) ([33be129](33be129)) * change z-index of freeze component to make it appear above all components ([f6ebae9](f6ebae9)), closes [#20538](#20538) * child row form should be above freeze screen ([8d4402e](8d4402e)) * Consider global default in user perm ([87e1aee](87e1aee)) * Consider user perimission default in get_user_default function ([24f6931](24f6931)) * dont create communication for auto repeat notification ([#20606](#20606)) ([#20611](#20611)) ([e9fc2ae](e9fc2ae)) * german translation of workflow state ([#20609](#20609)) ([#20616](#20616)) ([4d7a080](4d7a080)) * **grid row:** fix prettier hook check ([583e1d4](583e1d4)) * **grid row:** fix update_docfield_property function not updating grid row ([a2e9cc0](a2e9cc0)) * improved validation in `add_comment` ([#20520](#20520)) ([4d920fa](4d920fa)) * **ListView:** Evaluate sort_field sort_order within listviews based on DocTypes Definition ([#20482](#20482)) ([b560ccd](b560ccd)) * log requests even if no response ([#20638](#20638)) ([#20640](#20640)) ([a43c11e](a43c11e)) * minor oauth doctypes enhancements ([#20613](#20613)) ([75300f7](75300f7)) * **pretty-date:** plural form when the value is 1 ([#20619](#20619)) ([#20642](#20642)) ([7f6a557](7f6a557)) * track workspace changes ([#20649](#20649)) ([#20650](#20650)) ([5f54325](5f54325)) * validate if doctype exists before syncing customisations (backport [#20598](#20598)) ([#20645](#20645)) ([9a39bf8](9a39bf8)) ### Features * make report name translatable ([#20608](#20608)) ([#20618](#20618)) ([ed49e83](ed49e83)) ### Performance Improvements * Don't re-initate sessions in realtime.py ([#20577](#20577)) ([7480b86](7480b86))
frappe-pr-bot
pushed a commit
that referenced
this pull request
Apr 11, 2023
# [13.53.0](v13.52.0...v13.53.0) (2023-04-11) ### Bug Fixes * allow `reset_otp_secret` only if Two Factor Auth is enabled (backport [#20506](#20506)) ([#20560](#20560)) ([e8025a4](e8025a4)) * better permission error for query_report ([#20643](#20643)) ([#20646](#20646)) ([d972af8](d972af8)) * change z-index of freeze component to make it appear above all components ([1878b87](1878b87)), closes [#20538](#20538) * child row form should be above freeze screen ([9201e84](9201e84)) * client script add to instead of replace ([0c7ac16](0c7ac16)) * client_script default value ([9ed7851](9ed7851)) * german translation of workflow state ([#20609](#20609)) ([#20615](#20615)) ([3769bdf](3769bdf)) * **grid row:** fix prettier hook check ([9309687](9309687)) * **grid row:** fix update_docfield_property function not updating grid row ([558f908](558f908)) * **ListView:** Evaluate sort_field sort_order within listviews based on DocTypes Definition ([#20482](#20482)) ([ba3cf84](ba3cf84)) * log requests even if no response ([#20638](#20638)) ([#20639](#20639)) ([ae4f7dd](ae4f7dd)) * no optional chaining in v13 ([d08627b](d08627b)) * **pretty-date:** plural form when the value is 1 ([#20619](#20619)) ([#20641](#20641)) ([4d6b776](4d6b776)) * validate if doctype exists before syncing customisations ([#20598](#20598)) ([#20644](#20644)) ([32ba65f](32ba65f)) ### Features * add context to confirm dailog ([0e21299](0e21299)) * add context to prompt dialog ([1bbf9c9](1bbf9c9)) * make report name translatable (backport [#20608](#20608)) ([#20617](#20617)) ([a92e69e](a92e69e)) * **minor:** log datetime in worker log (backport [#20414](#20414)) ([#20569](#20569)) ([dccb6af](dccb6af))
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the issue that the defined "Sort Field" and "Sort Order" from a DocTypes definition or Customize Form has never been evaluated within the listView in the front end.
This closes #18523