-
Notifications
You must be signed in to change notification settings - Fork 277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
modify setup instrcution for adjusting almond environment #43
Conversation
I realized making a mistake that almond setup instruction order. |
Thank you for noticing this! I think it looks pretty good to me, I think we should have a couple people with different systems test it out. @chick @edwardcwang @azidar |
I'll take a look. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works fine for me (Ubuntu 18.10)
Thank you for checking my pull request and modifying a mistake. |
Hmm, does this change the Scala version? Seems like there are some errors that might be related to structural typing:
(This is a fresh test on Mac OS X, Java 8) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs an -Xsource=2.11
flag
Sorry, I believe that I may have spoken too quickly. The install instructions work fine but since it defaults to Scala 2.12, structural types (used e.g. in IOs) is broken, so we need a way to pass a (The error is also reproducible on Ubuntu 18.10) |
Thanks your reporting that failed compilation. You are right and that problem is occurred on my environment:
Sorry for no checking to run chisel basic code, because I've just started to learn Chisel. |
In edwardcwang's advise, I changed Scala version to build almond in d4868c8.
And I can run Chisel's code Could you check it again? |
Thanks for being responsive and helping to fix the PR! I'll take a look at it within the next few days. Was there not a way to get it to build with 2.12? For the Chisel builds we do with sbt we are able to use 2.12 with the |
Thanks for replying my comment. At first, I tried to use scalacOptions ++= Seq(
"-Xsource=2.11",
) But it didn't work for me. After that trial, I checked .travis.yml file and found |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think is is fine now. Filed #45 to get it working with 2.12+ eventually
Thnaks for merging the PR. |
When I tried to set up Chisel Bootcamp environment, jupyter-scala setup was changed:
So, I changed README.md to match current setup instructions.