Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modify setup instrcution for adjusting almond environment #43

Merged
merged 5 commits into from
Oct 15, 2018

Conversation

diningyo
Copy link
Contributor

@diningyo diningyo commented Oct 6, 2018

When I tried to set up Chisel Bootcamp environment, jupyter-scala setup was changed:

  • jupyter-scala github URL changed and redirecting to https://github.com/almond-sh/almond.git
  • the module name was change to almond from jupyter-scala (maybe)
  • almond setup method is changed to use coursier.

So, I changed README.md to match current setup instructions.

@diningyo
Copy link
Contributor Author

diningyo commented Oct 8, 2018

I realized making a mistake that almond setup instruction order.
So I modified setup instruction again in da5ea3a.

@grebe
Copy link
Contributor

grebe commented Oct 11, 2018

Thank you for noticing this! I think it looks pretty good to me, I think we should have a couple people with different systems test it out. @chick @edwardcwang @azidar

@edwardcwang
Copy link
Collaborator

I'll take a look.

Copy link
Collaborator

@edwardcwang edwardcwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works fine for me (Ubuntu 18.10)

@diningyo
Copy link
Contributor Author

Thank you for checking my pull request and modifying a mistake.

@diningyo diningyo closed this Oct 11, 2018
@diningyo diningyo deleted the modifySetup branch October 11, 2018 14:44
@diningyo diningyo restored the modifySetup branch October 11, 2018 14:45
@diningyo diningyo reopened this Oct 11, 2018
@edwardcwang
Copy link
Collaborator

edwardcwang commented Oct 11, 2018

Hmm, does this change the Scala version? Seems like there are some errors that might be related to structural typing:

cmd5.sc:12: value out is not a member of chisel3.Bundle
  io.out := io.in
     ^cmd5.sc:12: value in is not a member of chisel3.Bundle
  io.out := io.in
               ^Compilation Failed

(This is a fresh test on Mac OS X, Java 8)

Copy link
Collaborator

@edwardcwang edwardcwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs an -Xsource=2.11 flag

@edwardcwang
Copy link
Collaborator

edwardcwang commented Oct 11, 2018

Sorry, I believe that I may have spoken too quickly. The install instructions work fine but since it defaults to Scala 2.12, structural types (used e.g. in IOs) is broken, so we need a way to pass a -Xsource=2.11 flag to the Scala compiler to make it work.

(The error is also reproducible on Ubuntu 18.10)

@diningyo
Copy link
Contributor Author

Thanks your reporting that failed compilation. You are right and that problem is occurred on my environment:

  • Ubuntu 16.04 LTS
  • scala 2.12.7
  • almond 0.1.9

Sorry for no checking to run chisel basic code, because I've just started to learn Chisel.
Anyway I'll check up your advice which add an -Xsource=2.11 flags and try it.

@diningyo
Copy link
Contributor Author

In edwardcwang's advise, I changed Scala version to build almond in d4868c8.
The points are as follows:

  • When cloning almond github, indicating v0.1.9 version tag (for matching almond version obviously)
  • The Scala version for building almond is changed from 2.12.7 to 2.11.12.

And I can run Chisel's code io.out := io.in in module2.

Could you check it again?

@edwardcwang
Copy link
Collaborator

edwardcwang commented Oct 13, 2018

Thanks for being responsive and helping to fix the PR!

I'll take a look at it within the next few days. Was there not a way to get it to build with 2.12? For the Chisel builds we do with sbt we are able to use 2.12 with the -Xsource=2.11 flag.

@diningyo
Copy link
Contributor Author

Thanks for replying my comment.

At first, I tried to use -Xsource=2.11 flag, so I edited almond's build.sbt file and rebuilt it.
Added option is below.

scalacOptions ++= Seq(
  "-Xsource=2.11",
)

But it didn't work for me.
Is that trial wrong ?

After that trial, I checked .travis.yml file and found scala: 2.11.12 at include section.
So I changed SCALA_VERSION setting. And this time, it works for me.

Copy link
Collaborator

@edwardcwang edwardcwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think is is fine now. Filed #45 to get it working with 2.12+ eventually

@edwardcwang edwardcwang merged commit 53e9962 into freechipsproject:master Oct 15, 2018
@diningyo
Copy link
Contributor Author

Thnaks for merging the PR.
I understand your comment for future plan #45 .
If I found the resoultion, I would create PR.

@diningyo diningyo deleted the modifySetup branch October 17, 2018 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants