Skip to content

Conversation

@srkds
Copy link
Contributor

@srkds srkds commented Jan 20, 2022

Checklist:

Closes freeCodeCamp/freeCodeCamp#44731

fixed typo by removing 'n' from statement '...questionnaire.sh....'

@srkds
Copy link
Contributor Author

srkds commented Jan 20, 2022

#44731
issue

@ilenia-magoni
Copy link

I am curious why all the \r added... @moT01 what do you say?

@gikf
Copy link
Member

gikf commented Jan 24, 2022

There are two factors to that:

  • Git replaces line endings to \r\n locally on windows, by default. When committing git replaces line ending with just \n, so \r in the line endings doesn't make it into commits.
  • CodeRoad cli generates tutorial.json using file with \r\n. Which is how \r\n make into the generated strings.

I guess it could be tried to force git using just \n line ending in the repository, with .gitattributes file having:

* text eol=lf

@moT01
Copy link
Member

moT01 commented Jan 24, 2022

Thanks for clarifying that @gikf. I don't think they cause any problems, but do you think you can remove all those from this PR @srkds?

Copy link
Member

@moT01 moT01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉 Thanks for fixing this @srkds 👍

I removed all those real quick, it should be good to go

@moT01 moT01 merged commit 3ffc726 into freeCodeCamp:main Jan 24, 2022
@srkds
Copy link
Contributor Author

srkds commented Jan 25, 2022

Thanks 🎉 @gikf, @ieahleen reviewers, for your time and efforts.

@moT01 Thank you🙌 for rebuilding the JSON file and approving this PR 🚀

moT01 added a commit to moT01/learn-bash-scripting-by-building-five-programs that referenced this pull request Feb 5, 2024
* fix: fixed typo by removing 'n' in section 90

* update json

* rebuild json

Co-authored-by: moT01 <20648924+moT01@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Typo in Lesson 10 in Learn Bash Scripting by Building Five Programs

4 participants