break OnAction and OnEnter canellation tests #170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabrielittner
changed the title
gabrielittner
force-pushed
the
tests-unconfined
branch
from
2b27ea0
to
dabf29c
Compare
gabrielittner
force-pushed
the
tests-cancel
branch
from
a69916a
to
0c509d2
Compare
sockeqwe
approved these changes
Jul 30, 2021
|
Lets merge all these back into |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on top of #169.
With all the other stuff out of the way I was now finally able to reproduce #128 in tests. Now that it's running asynchronously all that needed to be done is moving the
assertFalsefor reached down. Similar to case 3 in #169 the assertion happened before the action was processed in the state machine soreachedwas stillfalsebut it would change a bit later. It would have been enough to move them one line down after the nextexpectItembut I moved them to the end where they should always work.Unfortunately I still can't break a test for #166/collectWhileInState.