remove onEnter flatMapPolicy and fix cancellation when leaving state #174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sockeqwe
approved these changes
Aug 1, 2021
| @@ -576,10 +576,9 @@ could complete before the first execution (because using a random time of waitin | |||
| - `CONCAT`: In contrast to `MERGE` and `LATEST` `CONCAT` will not run `on<BarAction>` in parallel and will not cancel | |||
| any previous execution. Instead, `CONCAT` will preserve the order and execute one block after another. | |||
|
|
|||
| All execution blocks can specify a `FlatMapPolicy`: | |||
| All execution blocks except `onEnter` can specify a `FlatMapPolicy`: | |||
| @@ -59,13 +59,11 @@ class InStateBuilderBlock<InputState : S, S : Any, A : Any>( | |||
| * TODO add a sample | |||
| */ | |||
| fun onEnter( | |||
| flatMapPolicy: FlatMapPolicy = FlatMapPolicy.LATEST, | |||
| .filter { it == MapStateChange.StateChanged.ENTERED } | ||
| .flatMapWithPolicy(flatMapPolicy) { | ||
| setStateFlow(getState) | ||
| .map { isInState(getState()) } |
There was a problem hiding this comment.
Thanks, this is a mich simpler implementation 🙏
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #171 and adresses the onEnter part of #128.
The old
flatMapWithPolicydidn't get any events when leaving the state which is why it didn't cancel even if it was usingLATEST. The new implementation turns each action emission to anisInStateboolean and then has aflatMapLatestthat will only return the onAction Flow if the boolean was true. This way the previousFlowwill get cancelled whenisInStatechanges from true to false.distintUntilChangedis used to ignore any additional emissions after the firsttrue.Instead of
mapto a boolean anddistintUntilChangedthis could also usefilterStatefrom theCollectWhileInStateimplementation. However this seems a lot less complex to me and I can't think of any issues with this implementation.