Skip to content

Commit 3f2f5d9

Browse files
committed
Fix meza migrate-wikis
task 'Set Primary wiki when no existing declarative config' was broken with an undefined variable The map filter was trying to loop a variable in a non-loop context so the Jinja2 template logic was wrong `sudo meza migrate-wikis monolith` works now instead an 'undefined variable' error Fixes Issue #101 Use a declarative wiki ID
1 parent 8087fde commit 3f2f5d9

File tree

1 file changed

+13
-10
lines changed
  • src/roles/migrate-to-declarative-wikis/tasks

1 file changed

+13
-10
lines changed

src/roles/migrate-to-declarative-wikis/tasks/main.yml

Lines changed: 13 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -97,17 +97,20 @@
9797
- name: Set default primary wiki when no existing configuration
9898
set_fact:
9999
discovered_wikis: >-
100-
{{
101-
discovered_wikis | map('combine', {'primary': (item.id == 'demo')}) | list
102-
if (discovered_wikis | selectattr('id', 'equalto', 'demo') | list | length > 0)
103-
else (
104-
discovered_wikis[:1] | map('combine', {'primary': true}) | list +
105-
discovered_wikis[1:] | map('combine', {'primary': false}) | list
106-
) if discovered_wikis | length > 0
107-
else []
108-
}}
100+
{%- set updated_wikis = [] -%}
101+
{%- set demo_exists = discovered_wikis | selectattr('id', 'equalto', 'demo') | list | length > 0 -%}
102+
{%- if demo_exists -%}
103+
{%- for wiki in discovered_wikis -%}
104+
{%- set _ = updated_wikis.append(wiki | combine({'primary': (wiki.id == 'demo')})) -%}
105+
{%- endfor -%}
106+
{%- elif discovered_wikis | length > 0 -%}
107+
{%- set _ = updated_wikis.append(discovered_wikis[0] | combine({'primary': true})) -%}
108+
{%- for wiki in discovered_wikis[1:] -%}
109+
{%- set _ = updated_wikis.append(wiki | combine({'primary': false})) -%}
110+
{%- endfor -%}
111+
{%- endif -%}
112+
{{ updated_wikis }}
109113
when: existing_primary_wikis | length == 0
110-
when: discovered_wikis is defined and discovered_wikis | length > 0
111114

112115
- name: Add wikis without base.php files (fallback)
113116
set_fact:

0 commit comments

Comments
 (0)