Skip to content

Commit

Permalink
fix(sct.py): kms resoruces cleanup with all regions
Browse files Browse the repository at this point in the history
currently if no region is defined, the kms cleanup breaks cause of:
`raise ValueError("'region_names' parameter cannot be empty")`

adding the need change, so it would be able to work across
all regions when needed
  • Loading branch information
fruch committed Dec 14, 2023
1 parent d3c93ec commit 9016c20
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion sdcm/utils/common.py
Original file line number Diff line number Diff line change
Expand Up @@ -621,7 +621,7 @@ def clean_cloud_resources(tags_dict, config=None, dry_run=False): # pylint: dis
clean_test_security_groups(tags_dict, regions=aws_regions, dry_run=dry_run)
clean_placement_groups_aws(tags_dict, regions=aws_regions, dry_run=dry_run)
if cluster_backend == 'aws':
clean_aws_kms_alias(tags_dict, config.region_names)
clean_aws_kms_alias(tags_dict, aws_regions or all_aws_regions())
if cluster_backend in ('gce', 'k8s-gke', ''):
for project in gce_projects:
with environment(SCT_GCE_PROJECT=project):
Expand Down

0 comments on commit 9016c20

Please sign in to comment.