types and arrays in F# attribute contructor arguments #387
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // TODO: typeof<..> in attribute values | ||
| // TODO: arrays in attribute values | ||
| | Expr.Op (TOp.Array,_,a,_) -> box [| for i in a -> evalFSharpAttribArg g i |] | ||
| | TypeOfExpr g ty -> box ty |
There was a problem hiding this comment.
These uses of "box" are a bit unusual for the way much of the compiler is written. I suppose it does make for a minimal diff, which is good, but could you add a comment to evalFSharpAttribArg to indicate the range of objects that can be returned from the function?
|
One comment on the code - otherwise this looks great |
dsyme
added a commit
that referenced
this pull request
Jul 31, 2015
types and arrays in F# attribute contructor arguments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable reading attribute constructor argument values defined with
typeofor array syntax. Value is a boxedFSharpTypeor boxedobj[].Notes:
I also experimented with correct handling
typedefofbut that would require some additional functions to look upSystem.TupleandFSharpFunccases properly.Also, reading arrays and types from IL seemed to have some deeper issues in deserialization.