Project cracking fix child references #478
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| // On some versions of Mono the referenced projects are already | ||
| // correctly included, so we make sure there aren't any duplicates | ||
| let cmdOptions = Array.ofSeq (Set.union (set parsedProject.Options) |
There was a problem hiding this comment.
Hmm.. I'd be more comfortable if
- keep the options in the same order and
- we only remove duplicates for
-roptions. I'm concerned that sequences like--optimize---optimize+--optimize-will just become--optimize---optimize+- I'm not sure this can really happen but it's best to avoid the possibility.
There was a problem hiding this comment.
Very good point, adjusted significantly.
|
One comment - if you can fix that then we can merge. Great to see things passing. |
|
OK, all good. |
dsyme
added a commit
that referenced
this pull request
Dec 2, 2015
…eferences Project cracking fix child references
|
Great! |
|
@dsyme should we go ahead and publish a new NuGet package then? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix #477, depends on #476