integrate visualfsharp's latest master #885
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This should help solve #884 |
|
Thank you! |
|
Could you do a version bump as well? |
|
Could you do an fcs version bump as well? https://github.com/fsharp/FSharp.Compiler.Service/blob/master/fcs/fcs.props#L6 |
|
Bump to 26.0.1 and search for 25.0.1 to check we get all occurrences |
|
@baronfel Can you do the version bump in another PR? thanks :) |
|
Yep, I'll get right on that. Thanks for the review/merge @dsyme! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This seems to be ok, the tests and nuget seems to work alright, with one exception:
There are two tests that key off of the methods on
System.String, but in some tests runs they include the newAsMemoryandAsSpanmethods, but some they do not.