Skip to content

Conversation

xp44mm
Copy link
Contributor

@xp44mm xp44mm commented Aug 27, 2018

because xunit is my used lib, maybe some body else need it also.

@xp44mm
Copy link
Contributor Author

xp44mm commented Aug 27, 2018

just add file ObservableSpecs.xunit.fs. others no change.

@stijnmoreels
Copy link
Member

I think you forgot to add the paket.references/paket.dependencies for xUnit?
xUnit is also my preffered testing framework \w FsCheck; but should check with @panesofglass .

Also, if we would move the xUnit; I would make the change complete and also update all the other tests and migrate to xUnit.

@xp44mm
Copy link
Contributor Author

xp44mm commented Aug 28, 2018

i compile pass the tests in my separate project. but some functionality i can't make sense. and i can't find them in api doc. that is:
open FSharp.Control.Reactive.Testing.Marbles
Observable.switchMap
Observable.exhaustMap
Observable.catchOption
Observable.catchResult
Observable.consumeMap
Observable.consumeNextOn
Observable.serve
so. i comment them out with whole Fact it belong. let tests pass.

@xp44mm
Copy link
Contributor Author

xp44mm commented Aug 28, 2018

i have converted all test files. and run the tests is correctly.

@panesofglass
Copy link
Collaborator

I'm fine switching to xUnit. Do we know why the builds are failing?

@panesofglass
Copy link
Collaborator

Looks like the builds fail due to incorrect dependency listings: Package FsCheck.Xunit was not found in group Main of the paket.lock file.

@panesofglass panesofglass merged commit dd30e66 into fsprojects:master May 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants