This repository was archived by the owner on Oct 31, 2021. It is now read-only.
Move to FSharp 4.1.25 and mono 5.0.1.1 #31
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SteveDesmond-ca
suggested changes
Aug 8, 2017
4.1.25/core/Dockerfile
Outdated
| # Download, validate against checksum (from https://dotnetcli.blob.core.windows.net/dotnet/checksums/1.0.4-1.1.1-sharedfx-SHA.txt), | ||
| # install runtime. | ||
| RUN echo "4477a1592779f439091d8432c456b6f187d7aec8ca016b214f0aa483867c8fdd dotnet-dev-debian-x64.$DOTNET_SDK_VERSION.tar.gz" >> dotnetcore-CHECKSUM \ | ||
| && curl -SL $DOTNET_SDK_DOWNLOAD_URL --output dotnet-dev-debian-x64.$DOTNET_SDK_VERSION.tar.gz \ |
There was a problem hiding this comment.
This line fails because curl isn't installed. Installing curl leads to an SSL error. I noticed this was the first to use jessie-slim as the base. I think it might be a little too slim! Kind of questioning this whole file again, given its similarity to the microsoft/dotnet image.
There was a problem hiding this comment.
@SteveDesmond-ca I dropped it for the time being, as I just let it ride along and really just the mono image needs an update.
SteveDesmond-ca
approved these changes
Aug 8, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This bumps the FSharp version to 4.1.25 which has some build and packaging optimizations since this also moves to mono 5.0.1.1 which supports msbuild.
Since mono 5.0 supports Debian Jessie, the base OS for this image is also Jessie now.
CC: @SteveDesmond-ca