http: only close connector if it is available

Author: isidentical

fsspec/implementations/http.py

@@ -123,9 +123,10 @@ def close_session(loop, session):
                 return
             except (TimeoutError, FSTimeoutError):
                 pass
-        if session._connector is not None:
+        connector = getattr(session, "_connector", None)
+        if connector is not None:
             # close after loop is dead
-            session._connector._close()
+            connector._close()
 
     async def set_session(self):
         if self._session is None:

fsspec/implementations/tests/test_http.py

@@ -475,6 +475,25 @@ def test_put_file(server, tmp_path, method, reset_files):
     assert fs.cat(server + "/hey_3") == b"yyy"
 
 
+async def get_aiohttp():
+    from aiohttp import ClientSession
+
+    return ClientSession()
+
+
+async def get_proxy():
+    class ProxyClient:
+        pass
+
+    return ProxyClient()
+
+
+@pytest.mark.parametrize("get_client", [get_aiohttp, get_proxy])
+def test_close(get_client):
+    fs = fsspec.filesystem("http", skip_instance_cache=True)
+    fs.close_session(None, asyncio.run(get_client()))
+
+
 @pytest.mark.xfail(
     condition=sys.flags.optimize > 1, reason="no docstrings when optimised"
 )