Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove silly ERROR logging message due to Intel compression additions #483

Merged
merged 1 commit into from
Apr 12, 2019

Conversation

nh13
Copy link
Member

@nh13 nh13 commented Apr 12, 2019

And the JAR gets bigger :/

@nh13 nh13 requested a review from tfenne April 12, 2019 04:22
@nh13
Copy link
Member Author

nh13 commented Apr 12, 2019

The message was:

ERROR StatusLogger Log4j2 could not find a logging implementation. Please add log4j-core to the classpath. Using SimpleLogger to log to the console...

@nh13
Copy link
Member Author

nh13 commented Apr 12, 2019

Without a config file we get this message:

ERROR StatusLogger No log4j2 configuration file found. Using default configuration: logging only errors to the console.

@codecov-io
Copy link

codecov-io commented Apr 12, 2019

Codecov Report

Merging #483 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #483   +/-   ##
=======================================
  Coverage   95.64%   95.64%           
=======================================
  Files          92       92           
  Lines        5443     5443           
  Branches      684      684           
=======================================
  Hits         5206     5206           
  Misses        237      237

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2d5aaa6...d24c92f. Read the comment docs.

@nh13 nh13 merged commit 9590c71 into master Apr 12, 2019
@nh13 nh13 deleted the nh_remove_intel_error_message branch April 12, 2019 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants