BotApp.java:57-59: Refactor this class: move actual logic...

[0pdd]

The puzzle 1-b3595789 from #1 has to be resolved:

ghman/src/main/java/com/g4s8/ghman/bot/BotApp.java

Lines 57 to 59 in a8f587e

	* @todo #1:30min Refactor this class:
	* move actual logic to separate takes and keep only
	* composition structure in this class.

The puzzle was created by @g4s8 on 22-May-19.

If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.

[0crat]

Job #2 is now in scope, role is DEV

[0crat]

@g4s8/z everybody who has role DEV is banned at #2; I won't be able to assign anyone automatically; consider assigning someone manually (as in §19), or invite more people (as in §51), or remove the job from the scope (as in §14)

[0crat]

The job #2 assigned to @samihibrahim/z, here is why; the budget is 30 minutes, see §4; please, read §8 and §9; if the task is not clear, read this and this; there will be no monetary reward for this job

[samihibrahim]

@0crat wait while PR #21 is merged

[0crat]

@0crat wait while PR #21 is merged (here)

@samihibrahim The impediment for #2 was registered successfully by @samihibrahim/z

[samihibrahim]

@g4s8 I am not sure if I broke something or what. But why PDD is not closing this issue?

[g4s8]

@samihibrahim there're few pdd errors:

ERROR: Puzzle src/main/java/com/g4s8/ghman/bot/TkNotifications.java:40-40 has a very short description of just 3 words while a minimum of 10 is required
ERROR: Puzzle src/main/java/com/g4s8/ghman/web/PsUserById.java:30-30 has a very short description of just 5 words while a minimum of 10 is required
ERROR: Puzzle src/main/java/com/g4s8/ghman/web/TkGitHubAuthorization.java:39-39 has a very short description of just 5 words while a minimum of 10 is required
ERROR: Puzzle src/main/java/com/g4s8/ghman/web/FkGitHubAuthRedirection.java:35-35 has a very short description of just 5 words while a minimum of 10 is required
ERROR: 4 errors, see log above

As I can see with git blame you submitted wrong-formatted puzzles which can't be processed by pdd, you need to fix 4 puzzles to close this issue.

it's my bad, I didn't configure pdd checks for Rultor and CI to see this error before merge, feel free to submit a ticket about it and I'll fix it it was fixed in last commit, see https://circleci.com/gh/g4s8/ghman/101.

[samihibrahim]

@g4s8 well, my bad. The problem is these puzzles are from different issues (#2 & #4) and both PRs are closed now. Should I create a single new PR fixing all four puzzles? or two new PR for each issue? or create a single new Issue and fix it with its own PR?

[g4s8]

@samihibrahim just create a single PR with all puzzle fixes

[0pdd]

The puzzle 1-b3595789 has disappeared from the source code, that's why I closed this issue.

[0pdd]

@0pdd 5 puzzles #34, #35, #36, #37, #38 are still not solved.

[0crat]

@ammaratef45/z please review this job completed by @samihibrahim/z, as in §30; the job will be fully closed and all payments will be made when the quality review is completed

[0crat]

Job #2 is not in the agenda of @samihibrahim/z, can't inspect

[0crat]

The job #2 is now out of scope

[ammaratef45]

@samihibrahim

All commit messages have links to issues

this rule was violated in your PR, please confirm you would take of that in the future.

[samihibrahim]

@ammaratef45 confirmed.

[ammaratef45]

@samihibrahim Thanks

[ammaratef45]

@0crat quality acceptable

[0crat]

Order was finished, quality is "acceptable": +30 point(s) just awarded to @samihibrahim/z

[0crat]

Quality review completed: +4 point(s) just awarded to @ammaratef45/z

[0pdd]

@0pdd 4 puzzles #34, #35, #36, #37 are still not solved; solved: #38.

[0pdd]

@0pdd 3 puzzles #34, #35, #36 are still not solved; solved: #37, #38.

[0pdd]

@0pdd 5 puzzles #34, #36, #82, #83, #84 are still not solved; solved: #35, #37, #38.

[0pdd]

@0pdd 4 puzzles #34, #82, #83, #84 are still not solved; solved: #35, #36, #37, #38.