Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ADR for including order in digests #17

Merged
merged 2 commits into from
Sep 22, 2021
Merged

add ADR for including order in digests #17

merged 2 commits into from
Sep 22, 2021

Conversation

nsheff
Copy link
Member

@nsheff nsheff commented Aug 25, 2021

Explains the decision that the final digests MUST reflect sequence order (but does not specify exactly how).

@nsheff
Copy link
Member Author

nsheff commented Sep 8, 2021

@tcezard and @andrewyatz Can you approve this?

Copy link
Collaborator

@andrewyatz andrewyatz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good and appears to be a truthful summary of the discussions.

@nsheff
Copy link
Member Author

nsheff commented Sep 8, 2021

@sveinugu does this accurately reflect what you think about this topic as well?

@sveinugu
Copy link
Collaborator

sveinugu commented Sep 8, 2021

@sveinugu does this accurately reflect what you think about this topic as well?

Not sure whether we have concluded that the top-level digest is required to be ordered, which seems to be what the decision entails.

Also "collections that identical" -> "collections that are identical"

@nsheff
Copy link
Member Author

nsheff commented Sep 22, 2021

Not sure whether we have concluded that the top-level digest is required to be ordered, which seems to be what the decision entails.

@sveinugu I think it's not saying anything about the level, just that the final solution must be able to account for different orders, so I think it accurately reflects what we've agreed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants