Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cache binaries for MIRA 4.9.6 #84

Merged
merged 2 commits into from
Aug 11, 2016
Merged

Conversation

peterjc
Copy link
Contributor

@peterjc peterjc commented Aug 10, 2016

Cache the current latest MIRA development binaries, which I want to use from https://github.com/peterjc/galaxy_mira/blob/master/packages/package_mira_4_9_6/tool_dependencies.xml

Also recording the original URLs for MIRA 4.0.2 (still live) and MIRA 4.9.5 (defunct), which seem more useful than the /srv/nginx/... internal path which I assume was an implementation detail?

@peterjc
Copy link
Contributor Author

peterjc commented Aug 10, 2016

See #82 about recording the old URLs in urls.tsv

mira 4.0.2 linux x64 http://downloads.sourceforge.net/project/mira-assembler/MIRA/stable/mira_4.0.2_linux-gnu_x86_64_static.tar.bz2 .tar.bz2 d3c74a6b402192e01d10adb8dbdc3450d4033fa0e7662ce5ce5de4f8c1967813 True
mira 4.9.5 linux x64 http://downloads.sourceforge.net/project/mira-assembler/MIRA/development/mira_4.9.5_2_linux-gnu_x86_64_static.tar.bz2 .tar.bz2 3848885cb041cd9bf7aa8f220dd3f084443f5060fa433b669f7d28880ba4c61f False
mira 4.9.6 darwin x64 http://downloads.sourceforge.net/project/mira-assembler/MIRA/development/mira_4.9.6_darwin15.4.0_x86_64_static.tar.bz2 3d0bb15adad0e1e27899d21223cb552968d34d35ad9b1184e85832fc0b3d22ce .tar.bz2 True
mira 4.9.6 linux z64 http://downloads.sourceforge.net/project/mira-assembler/MIRA/development/mira_4.9.6_linux-gnu_x86_64_static.tar.bz2 3c2c343a75045c2c69cb4aba283821d6e82202c37792af886aab0002a8194dee .tar.bz2 True
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

x64

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks... will fix and rebase.

@hexylena
Copy link
Member

seem more useful than the /srv/nginx/... internal path which I assume was an implementation detail?

we imported a number of packages that were on depot before but in an uncategorized fashion, so, yes, implementation detail.

@peterjc
Copy link
Contributor Author

peterjc commented Aug 10, 2016

The URL http://downloads.sourceforge.net/project/mira-assembler/MIRA/development/mira_4.9.5_2_linux-gnu_x86_64_static.tar.bz2 is defunct (giving an Error 404), but it seems TravisCI still attempts to verify the checksum...

@hexylena
Copy link
Member

@peterjc yes, this is true. In these cases we will gladly merge despite such complaints from Travis since this is the minority of cases.

@peterjc
Copy link
Contributor Author

peterjc commented Aug 10, 2016

It looks a bit fiddly to get the shell one-liner in https://github.com/galaxyproject/cargo-port/blob/master/.ci/check.sh to add an if condition to skip Error 404 URLs...

Confirmed live and that the checksums match.
@peterjc
Copy link
Contributor Author

peterjc commented Aug 10, 2016

Rebased fixing the typo, and without the MIRA 4.9.5 URL change which broke TravisCI

@hexylena
Copy link
Member

Invalid hash for http://downloads.sourceforge.net/project/mira-assembler/MIRA/development/mira_4.9.6_darwin15.4.0_x86_64_static.tar.bz2

other than this error, it looks ready to go

@peterjc
Copy link
Contributor Author

peterjc commented Aug 10, 2016

I'm confused,

$ curl -L http://downloads.sourceforge.net/project/mira-assembler/MIRA/development/mira_4.9.6_darwin15.4.0_x86_64_static.tar.bz2 | shasum -a 256
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
  0   419    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
100 19.7M  100 19.7M    0     0  8595k      0  0:00:02  0:00:02 --:--:-- 10.7M
3d0bb15adad0e1e27899d21223cb552968d34d35ad9b1184e85832fc0b3d22ce  -

and:

$ curl -L http://downloads.sourceforge.net/project/mira-assembler/MIRA/development/mira_4.9.6_linux-gnu_x86_64_static.tar.bz2  | shasum -a 256
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
  0   409    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
100 19.7M  100 19.7M    0     0  9596k      0  0:00:02  0:00:02 --:--:-- 11.1M
3c2c343a75045c2c69cb4aba283821d6e82202c37792af886aab0002a8194dee  -

Could SourceForge be doing something odd with different mirrors? Do you get the same checksums?

@bgruening
Copy link
Member

Grr, I had this before and could not explain it. SourceForge does some crazy things in the background. I have seen mirrors going from https to http and returning different checksums :(

@peterjc
Copy link
Contributor Author

peterjc commented Aug 11, 2016

Wow. The good news here is that for me from work, http and https give we the same checksum from SourceForge.

It would help if the TravisCI test reported a little more information - even if this means rewriting the one-liner into a bash loop or even switching it to Python?

@hexylena
Copy link
Member

It would help if the TravisCI test reported a little more information - even if this means rewriting the one-liner into a bash loop or even switching it to Python?

yeah, this had been on the todo list for a while. Guess it is time.

@hexylena
Copy link
Member

Ok, I have replaced the stupid bash oneline I wrote whilst trying to be too clever with a proper script. I am still working out the details of it, but it looks like your URLs validate under an updated script.

@hexylena
Copy link
Member

ERROR:root:File has bad hash! 3d0bb15adad0e1e27899d21223cb552968d34d35ad9b1184e85832fc0b3d22ce != .tar.bz2 in mira_4.9.6_darwin_x643d0bb15adad0e1e27899d21223cb552968d34d35ad9b1184e85832fc0b3d22ce
ERROR:root:File has bad hash! 3c2c343a75045c2c69cb4aba283821d6e82202c37792af886aab0002a8194dee != .tar.bz2 in mira_4.9.6_linux_x643c2c343a75045c2c69cb4aba283821d6e82202c37792af886aab0002a8194dee

your last two columns are mixed up. I'll add a check if it looks like a sha256, so we can warn about that much earlier in the process.

@peterjc
Copy link
Contributor Author

peterjc commented Aug 11, 2016

Easily done - having the TravisCI script check the length of the hash field seems a simple addition.

I'll update this pull request (which will trigger a retest)

@hexylena
Copy link
Member

hexylena commented Aug 11, 2016

easily done

dc44cfc now checks for sha256 like things :) Thanks for finding these bugs for us, and thank you for being patient while we fix them.

@peterjc
Copy link
Contributor Author

peterjc commented Aug 11, 2016

We have a green light - thanks for improving the TravisCI checks here @erasche

@hexylena hexylena merged commit 069a2ad into galaxyproject:master Aug 11, 2016
@peterjc peterjc deleted the mira_4_9_6 branch August 11, 2016 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants