This repository has been archived by the owner on Jul 24, 2020. It is now read-only.
Allow conda to be configured to use locally built packages. #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is required to run tests and such with new and updated local packages before they have been published.
nsoranzo
reviewed
Feb 24, 2017
| @@ -54,7 +55,8 @@ class CondaContext(installable.InstallableContext): | |||
|
|
|||
| def __init__(self, conda_prefix=None, conda_exec=None, | |||
| shell_exec=None, debug=False, ensure_channels='', | |||
| condarc_override=None, use_path_exec=USE_PATH_EXEC_DEFAULT, copy_dependencies=False): | |||
| condarc_override=None, use_path_exec=USE_PATH_EXEC_DEFAULT, | |||
| use_local=USE_LOCAL_DEFAULT, copy_dependencies=False): | |||
There was a problem hiding this comment.
I think I'd add use_local as last parameter (at least for consistency with how you call it in galaxy/tools/deps/resolvers/conda.py)
bgruening
approved these changes
Feb 24, 2017
|
Awesome - thanks for the reviews all. I made the change requested in master @nsoranzo. |
|
Test case for this PR included in galaxyproject/planemo#643. |
jmchilton
added a commit
to jmchilton/galaxy
that referenced
this pull request
Mar 9, 2017
- I added more flexibility to mulled operations to work around bugs on OS X (galaxyproject/galaxy-lib#50). - I added the ability to use local packages with the Conda resolver (galaxyproject/galaxy-lib#47) - this allows Galaxy when used with Planemo to use locally built packages. - I switched the default Conda prefix to miniconda3 so the name matches what Galaxy is actually installing. galaxyproject/galaxy-lib#48. This would never actually be used with Galaxy since we decided it should maintain its own prefix rather than using the default - it is important for Planemo though. There are some other bug fixes outside of these three main PRs related to the second point - minor refinements to get conda-build dependencies working and working automatically. - galaxyproject/galaxy-lib@bdacc4d - galaxyproject/galaxy-lib@1b7bca6 - galaxyproject/galaxy-lib@36b2e65
jmchilton
added a commit
to jmchilton/galaxy
that referenced
this pull request
Mar 11, 2017
- I added more flexibility to mulled operations to work around bugs on OS X (galaxyproject/galaxy-lib#50). - I added the ability to use local packages with the Conda resolver (galaxyproject/galaxy-lib#47) - this allows Galaxy when used with Planemo to use locally built packages. Including Nicola's suggested changes here (galaxyproject/galaxy-lib@6d53fc7). - I switched the default Conda prefix to miniconda3 so the name matches what Galaxy is actually installing. galaxyproject/galaxy-lib#48. This would never actually be used with Galaxy since we decided it should maintain its own prefix rather than using the default - it is important for Planemo though. - I synced the galaxy.tools.cwl package with my latest downstream work that provides updates for latest developments in cwltool. galaxyproject/galaxy-lib#53 - I added the ability to load tools via URI-like strings in addition to simple paths - this allows referencing URLs and Dockstore/GA4GH tools directly from the command-line with Planemo. galaxyproject/galaxy-lib#52 There are some other bug fixes outside of these three main PRs related to the second point - minor refinements to get conda-build dependencies working and working automatically. - galaxyproject/galaxy-lib@bdacc4d - galaxyproject/galaxy-lib@1b7bca6 - galaxyproject/galaxy-lib@36b2e65
jmchilton
added a commit
to jmchilton/galaxy
that referenced
this pull request
Mar 13, 2017
- I added more flexibility to mulled operations to work around bugs on OS X (galaxyproject/galaxy-lib#50). - I added the ability to use local packages with the Conda resolver (galaxyproject/galaxy-lib#47) - this allows Galaxy when used with Planemo to use locally built packages. Including Nicola's suggested changes here (galaxyproject/galaxy-lib@6d53fc7). - I switched the default Conda prefix to miniconda3 so the name matches what Galaxy is actually installing. galaxyproject/galaxy-lib#48. This would never actually be used with Galaxy since we decided it should maintain its own prefix rather than using the default - it is important for Planemo though. - I synced the galaxy.tools.cwl package with my latest downstream work that provides updates for latest developments in cwltool. galaxyproject/galaxy-lib#53 - I added the ability to load tools via URI-like strings in addition to simple paths - this allows referencing URLs and Dockstore/GA4GH tools directly from the command-line with Planemo. galaxyproject/galaxy-lib#52 There are some other bug fixes outside of these three main PRs related to the second point - minor refinements to get conda-build dependencies working and working automatically. - galaxyproject/galaxy-lib@bdacc4d - galaxyproject/galaxy-lib@1b7bca6 - galaxyproject/galaxy-lib@36b2e65
jmchilton
added a commit
to jmchilton/galaxy
that referenced
this pull request
Mar 13, 2017
- I added more flexibility to mulled operations to work around bugs on OS X (galaxyproject/galaxy-lib#50). - I added the ability to use local packages with the Conda resolver (galaxyproject/galaxy-lib#47) - this allows Galaxy when used with Planemo to use locally built packages. Including Nicola's suggested changes here (galaxyproject/galaxy-lib@6d53fc7). - I switched the default Conda prefix to miniconda3 so the name matches what Galaxy is actually installing. galaxyproject/galaxy-lib#48. This would never actually be used with Galaxy since we decided it should maintain its own prefix rather than using the default - it is important for Planemo though. - I synced the galaxy.tools.cwl package with my latest downstream work that provides updates for latest developments in cwltool. galaxyproject/galaxy-lib#53 - I added the ability to load tools via URI-like strings in addition to simple paths - this allows referencing URLs and Dockstore/GA4GH tools directly from the command-line with Planemo. galaxyproject/galaxy-lib#52 There are some other bug fixes outside of these three main PRs related to the second point - minor refinements to get conda-build dependencies working and working automatically. - galaxyproject/galaxy-lib@bdacc4d - galaxyproject/galaxy-lib@1b7bca6 - galaxyproject/galaxy-lib@36b2e65
jmchilton
added a commit
to jmchilton/galaxy
that referenced
this pull request
Mar 14, 2017
- I added more flexibility to mulled operations to work around bugs on OS X (galaxyproject/galaxy-lib#50). - I added the ability to use local packages with the Conda resolver (galaxyproject/galaxy-lib#47) - this allows Galaxy when used with Planemo to use locally built packages. Including Nicola's suggested changes here (galaxyproject/galaxy-lib@6d53fc7). - I switched the default Conda prefix to miniconda3 so the name matches what Galaxy is actually installing. galaxyproject/galaxy-lib#48. This would never actually be used with Galaxy since we decided it should maintain its own prefix rather than using the default - it is important for Planemo though. - I synced the galaxy.tools.cwl package with my latest downstream work that provides updates for latest developments in cwltool. galaxyproject/galaxy-lib#53 - I added the ability to load tools via URI-like strings in addition to simple paths - this allows referencing URLs and Dockstore/GA4GH tools directly from the command-line with Planemo. galaxyproject/galaxy-lib#52 There are some other bug fixes outside of these three main PRs related to the second point - minor refinements to get conda-build dependencies working and working automatically. - galaxyproject/galaxy-lib@bdacc4d - galaxyproject/galaxy-lib@1b7bca6 - galaxyproject/galaxy-lib@36b2e65
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is required to run tests and such with new and updated local packages before they have been published.