Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vuefy Job information #10353

Merged
merged 11 commits into from
Dec 3, 2020
Merged

Vuefy Job information #10353

merged 11 commits into from
Dec 3, 2020

Conversation

OlegZharkov
Copy link
Contributor

Rework another part of show_params.mako, this time we move Job Information to Vue.
We're almost there. After this PR, only job dependencies left and we finally can remove that .mako file
this PR depends on #10327
Exaple:

image

@OlegZharkov OlegZharkov changed the title Vuefy Job information [WIP] Vuefy Job information Oct 2, 2020
@mvdbeek
Copy link
Member

mvdbeek commented Oct 2, 2020

Can you pull stdout and stderr into the top-level view if they are present ? The extra link is kind-of silly.

@OlegZharkov
Copy link
Contributor Author

OlegZharkov commented Oct 3, 2020 •
edited
Loading

Can you pull stdout and stderr into the top-level view if they are present ? The extra link is kind-of silly.

Sorry, didn't really get it. What did you mean by top level view?
You didn't like the method or am i missing something? The method is created because of getAppRoot()

Update: yes, I guess it would make sense to crated a method to just return getAppRoot() and move stdout/err into html. I will do that

@OlegZharkov OlegZharkov force-pushed the job-information branch 2 times, most recently from 19bb90a to bdfcd7a Compare October 7, 2020 14:47
@OlegZharkov OlegZharkov changed the title [WIP] Vuefy Job information Vuefy Job information Oct 8, 2020
@OlegZharkov OlegZharkov marked this pull request as ready for review October 8, 2020 17:46
@OlegZharkov
Copy link
Contributor Author

OlegZharkov commented Nov 23, 2020 •
edited
Loading

I guess, I will rebase this to have Selenium testing in GHA

@mvdbeek
Copy link
Member

mvdbeek commented Nov 23, 2020

Damn, looks like the bibtex test failed. I'll look into that.

@OlegZharkov
Copy link
Contributor Author

JobStore could be reused for future work in converting show_params.mako

@OlegZharkov
Copy link
Contributor Author

OlegZharkov commented Dec 2, 2020 •
edited
Loading

Can someone with access remove status/WIP label here, please? So bot can assign 21.01 milestone

@github-actions github-actions bot added this to the 21.01 milestone Dec 3, 2020
@jmchilton jmchilton merged commit e366935 into galaxyproject:dev Dec 3, 2020
@github-actions
Copy link

github-actions bot commented Dec 3, 2020

This PR was merged without a "kind/" label, please correct.

@jmchilton
Copy link
Member

Awesome stuff - thanks so much!

@OlegZharkov
Copy link
Contributor Author

Awesome stuff - thanks so much!

thanks @jmchilton!

@martenson martenson mentioned this pull request Dec 12, 2022
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dannon dannon dannon left review comments

@mvdbeek mvdbeek mvdbeek left review comments

@jmchilton jmchilton Awaiting requested review from jmchilton

Assignees
No one assigned
Labels
area/API area/UI-UX kind/enhancement
Projects
None yet
Milestone
21.01
Development

Successfully merging this pull request may close these issues.
6 participants
@OlegZharkov @mvdbeek @jmchilton @dannon @nsoranzo @galaxybot