Revision of sharing component, adds url copy to clipboard feature #10754
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
dannon
reviewed
Nov 18, 2020
| @@ -82,15 +82,15 @@ import Vue from "vue"; | |||
| import BootstrapVue from "bootstrap-vue"; | |||
| import { FontAwesomeIcon } from "@fortawesome/vue-fontawesome"; | |||
| import { library } from "@fortawesome/fontawesome-svg-core"; | |||
| import { faClipboard, faEdit } from "@fortawesome/free-regular-svg-icons"; | |||
| import { faLink, faEdit } from "@fortawesome/free-solid-svg-icons"; | |||
There was a problem hiding this comment.
is faEdit available in both regular and solid?
There was a problem hiding this comment.
… reactive flag to hide edit field
guerler
force-pushed
the
history_clipboard
branch
from
447f5a6
to
e9f2143
Compare
|
@guerler A nice next step would be to fix up 'share with indivdiual user' so that it doesn't load a new page, but this is a great start and it's working well. Looks nice. |
jmchilton
added a commit
to jmchilton/galaxy
that referenced
this pull request
Nov 21, 2020
mvdbeek
pushed a commit
to mvdbeek/galaxy
that referenced
this pull request
Nov 22, 2020
mvdbeek
pushed a commit
to mvdbeek/galaxy
that referenced
this pull request
Nov 22, 2020
mvdbeek
pushed a commit
to mvdbeek/galaxy
that referenced
this pull request
Nov 22, 2020
|
This seems to remove the need to set 'Also make all objects within the history accessible.', just checking that that's intended, right? If so, that's fantastic, makes sharing SO much less bugprone on EU and other servers that enforce dataset privacy by default within history. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR revises the sharing component by removing legacy jquery helpers and introducing a slug input component. Additionally it adds a clipboard feature, allowing users to copy the url. It also applies conventional naming and formatting in consensus with newer components and use the font awesome components to render icons. Fixes #10732.