Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[20.09] Fix mule job messaging #11148

Merged
merged 1 commit into from
Jan 18, 2021

Conversation

mvdbeek
Copy link
Member

@mvdbeek mvdbeek commented Jan 15, 2021

Handler assignment via mule messaging passes around the job id, so we need to flush before we can assign.
Should fix #11146.

@github-actions github-actions bot added this to the 21.05 milestone Jan 15, 2021
@mvdbeek mvdbeek mentioned this pull request Jan 15, 2021
@mvdbeek mvdbeek changed the base branch from dev to release_20.09 January 15, 2021 18:33
@AjitPS
Copy link

AjitPS commented Jan 18, 2021

Ah, I tried updating my Galaxy from 19.01 to 20.09 and all works but jobs stuck in "new" state... we use Mule handlers too so hopefully pulling this will fix it. thanks

@nsoranzo nsoranzo closed this Jan 18, 2021
@nsoranzo nsoranzo reopened this Jan 18, 2021
@mvdbeek
Copy link
Member Author

mvdbeek commented Jan 18, 2021

@nsoranzo the circle-ci setup breaks when changing the base. Let me see if a rebase fixes that

@AjitPS
Copy link

AjitPS commented Jan 18, 2021

would be good to have this fix. thanks!

Handler assignment via mule messaging passes arpund the job id, so we
need to flush before we can assign.
Should fix galaxyproject#11146.
@AjitPS
Copy link

AjitPS commented Jan 18, 2021

awaiting this to be merged. would be great to have Mule job messaging and job submission resolved

@nsoranzo nsoranzo merged commit b94f89b into galaxyproject:release_20.09 Jan 18, 2021
@nsoranzo nsoranzo deleted the mule_messaging_fix branch January 18, 2021 16:42
@AjitPS
Copy link

AjitPS commented Jan 19, 2021

Thanks both.
FYI, I am trying to update our institute's Galaxy (since mid- last week) from v19.01 to v20.09. I pulled the release_20.09 code branch on Jan. 13th, and got it up and running on our end. Our galaxy 19.01 used to submit jobs via Slurm to our HPC and this job submission now stalls (stuck in "new" state).

I contacted @nsoranzo who suggested pulling this fix #11148 (pulled this commit only which has 2 files changed) but same issues persist.

I also noticed in .logs that 3 existing shed_tools (plink, vcftools-filter, hmmer_hmmalign) throwing continuous errors of missing datatypes and code exceptions while the tool panel is being populated. perhaps as they are not python3.

also get:
galaxy.tools.parameters.basic WARNING 2021-01-19 09:06:06,812 Datatype class not found for extension 'text', which is used in the 'format' attribute of parameter 'input_keep_ids'

Not sure how to proceed as my galaxy.yml, job_conf.xml etc look good and have restarted galaxy since pulling the fix too but my test jobs (very simple tools like: count lines in file, etc) are still stuck in "new" state. main Galaxy log shows job_id but handlers empty... not sure what I'm missing.

@AjitPS
Copy link

AjitPS commented Jan 19, 2021

e.g., on launching a test job:

galaxy_web_0.log:galaxy.web_stack.transport DEBUG 2021-01-19 09:57:07,036 [p:32189,w:1,m:0] [uWSGIWorker1Core0] Sending message to farm job-handlers: {"target": "job_handler", "params": {"task": "setup", "job_id": 175843}, "__classname__": "JobHandlerMessage"}

but handler logs empty and jobs_directory has no new dir.

@mvdbeek
Copy link
Member Author

mvdbeek commented Jan 19, 2021

@AjitPS please open an issue and describe your setup, including python version used and your job handler setup. The message your seeing here means the PR works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Job stuck in new state
3 participants