Parallelize client and server builds in dockerfile #11161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nuwang
commented
Jan 17, 2021
mvdbeek
approved these changes
Jan 18, 2021
There was a problem hiding this comment.
Looks good to me, can you also verify https://github.com/galaxyproject/galaxy/pull/11161/files#r559193525 ?
|
It may make sense to include this in 21.01 as well, since it could significantly speed up build times? |
|
No problem, I will backport it. |
jmchilton
approved these changes
Jan 18, 2021
|
This PR was merged without a "kind/" label, please correct. |
55 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modifies the k8s docker file so that client and server build stages are built in parallel, reducing total build time.
The uncached build time prior to this is ~18.5 minutes locally, which reduces to ~12.5 minutes, a ~33% reduction.
On dockerhub, there appears to be no benefit, as the builds don't seem to be parallelised in the free version.
This PR is dependent on: galaxyproject/ansible-galaxy#120