History beta poll decay time reset

[Nerdinacan]

The beta history poll slows down over time so we're not asking the server for useless things during periods of inactivity, but it makes sense to speed up whenever we start manipulating content.

I've modified how the polling works to include an observable that looks at the browser XHR object and emits an event when a matching method / url are detected, this emission is used to reset the decay time on the polling.

[dannon]

This doesn't seem to be working like I'd expect. I added debugging to the route matcher and that's firing (ROUTE MATCHED, SHOULD RESET), but it isn't resetting the decay in my hands, note the timestamps:

The other cruft you see logged is just a tap() I was debugging with.

[Nerdinacan]

Thanks man, I'll beat on it some more. Was trying to have a global solution that didn't involve us touching every outgoing ajax POST.

[dannon]

@Nerdinacan No worries at all -- I really like the approach, and the watching is all working great. We just need to get the restoration to $freshPoll or otherwise resetting decay working right.

[Nerdinacan]

@dannon

Yep got it. I think it was just misconfigured. I left a debug line in decay() so you can see it reset in the console.

On a side note I really wish there was a way to make prettier understand piped functions. I hate having to add prettier-ignore because prettier legitimately finds a lot of dumb formatting bugs. But it leaves every observable stream unintelligible.

[dannon]

@Nerdinacan I'll see what I can figure out. Agree it'd be great to just let prettier process these files (and notice issues), but putting all the piped stuff in a single line does indeed suck.

[dannon]

@Nerdinacan Thanks. This is working great now; I pushed a commit with minor cleanup and a typo fix but no functional changes.

I some digging into making prettier work better with RxJS in general, and it's an issue folks are aware of there. There have been a few attempts at it, and maybe they'll get it right at some point, but for now I'd just say scope // prettier-ignore to the most local block you need and just do it that way.

(for what it's worth, part of the problem here is actually our wide 120 character code width -- most of the rxjs is actually pretty decent to read when wrapped to 80)