Selenium test for library_import_dir
#11188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dannon
reviewed
Jan 20, 2021
| @@ -563,10 +563,16 @@ libraries: | |||
| download_button: '#download-btn' | |||
| delete_btn: '.toolbtn-bulk-delete' | |||
| toast_msg: '.toast-message' | |||
| select_import_dir_item: 'li[full_path="${name}"] .jstree-anchor' | |||
There was a problem hiding this comment.
Oof, I forgot jstree was here too and not just the toolshed -- one more thing to replace!
(this looks fine though)
There was a problem hiding this comment.
yeah, it's obsolete code from old library. user_import_dir utilizes the same
OlegZharkov
force-pushed
the
import-dir-test
branch
from
44a043b
to
b3bde59
Compare
OlegZharkov
force-pushed
the
import-dir-test
branch
from
b3bde59
to
e01c9f2
Compare
|
This PR was merged without a "kind/" label, please correct. |
mvdbeek
changed the title
library_import_dir
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement Selenium test, that imports dataset from
library_import_dir.We're almost done with lib code testing, only
user_library_import_dirleft (going to work on that)