-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace pipenv with poetry. Update all dependencies #11192
Conversation
I don't regret Pipenv - it was better than nothing, we're regularly upgrading our dependencies now. But it was really just barely better than nothing, I'm excited to see it go! Thanks so much. |
Yes, my mistake there. I'm reworking that part as per suggestions above, will rebase and ping you. Thanks for the feedback! |
4938734
to
4339fd7
Compare
Ready from my side. |
@nsoranzo Checking building one more time locally and then I'll merge, looks good to me. There's no firm requirement for pyjwt2, so it's good to go ahead and be ready for that with tests still passing against 1.7. Edit: Worked great. Much faster than pipenv, too! Thanks, this is a nice step forward for depenency management. I like the pyproject.toml addition, too, to keep all the tooling stuff in one spot -- I'm using the same in the black branch. |
This PR was merged without a "kind/" label, please correct. |
This was initially pinned in galaxyproject#11192 but I cannot recall why exactly.
This was initially pinned in galaxyproject#11192 but I cannot recall why exactly.
with the updated
make update-dependencies
.