Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace pipenv with poetry. Update all dependencies #11192

Merged
merged 3 commits into from
Jan 21, 2021

Conversation

nsoranzo
Copy link
Member

@nsoranzo nsoranzo commented Jan 20, 2021

with the updated make update-dependencies .

@jmchilton
Copy link
Member

I don't regret Pipenv - it was better than nothing, we're regularly upgrading our dependencies now. But it was really just barely better than nothing, I'm excited to see it go! Thanks so much.

@dannon
Copy link
Member

dannon commented Jan 21, 2021

@nsoranzo I tested a rerun of make update-dependencies and it looks good but I did notice the removal of the flake8 and other linting deps from pinned-dev-requirements.txt in my rebuild. Did something go wrong here, or were these inadvertently left in? 54329f9

@dannon dannon mentioned this pull request Jan 21, 2021
@nsoranzo
Copy link
Member Author

@nsoranzo I tested a rerun of make update-dependencies and it looks good but I did notice the removal of the flake8 and other linting deps from pinned-dev-requirements.txt in my rebuild. Did something go wrong here, or were these inadvertently left in? 54329f9

Yes, my mistake there. I'm reworking that part as per suggestions above, will rebase and ping you. Thanks for the feedback!

@nsoranzo
Copy link
Member Author

Ready from my side.

@dannon
Copy link
Member

dannon commented Jan 21, 2021

@nsoranzo Checking building one more time locally and then I'll merge, looks good to me. There's no firm requirement for pyjwt2, so it's good to go ahead and be ready for that with tests still passing against 1.7.

Edit: Worked great. Much faster than pipenv, too! Thanks, this is a nice step forward for depenency management. I like the pyproject.toml addition, too, to keep all the tooling stuff in one spot -- I'm using the same in the black branch.

@dannon dannon merged commit d3f4f7b into galaxyproject:dev Jan 21, 2021
@github-actions
Copy link

This PR was merged without a "kind/" label, please correct.

@nsoranzo nsoranzo deleted the update_dependencies branch January 21, 2021 22:53
nsoranzo added a commit to nsoranzo/galaxy that referenced this pull request Feb 28, 2023
This was initially pinned in galaxyproject#11192
but I cannot recall why exactly.
@nsoranzo nsoranzo mentioned this pull request Feb 28, 2023
4 tasks
nsoranzo added a commit to nsoranzo/galaxy that referenced this pull request Mar 1, 2023
This was initially pinned in galaxyproject#11192
but I cannot recall why exactly.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants