Manage folder rewrite in Vue & VueRouter #11259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OlegZharkov
changed the title
OlegZharkov
force-pushed
the
manage-folder-rewrite
branch
2 times, most recently
from
7021cda
to
8ddc0e2
Compare
OlegZharkov
force-pushed
the
manage-folder-rewrite
branch
from
7f02ac0
to
4a760f2
Compare
|
This PR was merged without a "kind/" label, please correct. |
|
Thanks @dannon for the fast review :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most importantly, this PR brings VueRouter to
AnalysisRouter.js.Since we do not reload page between
library folderandmanage permissionsanymore, it improves surfing speed dramatically.Also re-implementation of permission folder legacy backbone code. PR makes permissions view slightly more modern. It replaces paginated select2 with
vue-multiselect, might be a good example how to replace paginated select2.before:
now:
