[21.01] Fix mtx unbound error #11368
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
So now our linter is forcing bugs on us? 💢 |
mvdbeek
force-pushed
the
21_01_mtx_error
branch
2 times, most recently
from
e6da59b
to
3474094
Compare
and separate data lines and comment lines.
mvdbeek
force-pushed
the
21_01_mtx_error
branch
from
3474094
to
85980bb
Compare
|
Can't you just backport from dev? |
|
Sure, didn't know it was fixed on dev |
|
dev is still broken, fixing it would raise the linting error. But I see the data_lines calcualtion makes sense |
nsoranzo
approved these changes
Feb 14, 2021
|
Thank you @nsoranzo! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needed for the smorgasboard scanpy tutoial