Refactor display_applications API logic into DisplayApplicationsManager #11386

davelopez · 2021-02-16T13:36:09Z

Overview

This refactoring is in preparation for the FastAPI migration.

Added some API tests.
Replaced the old legacy_expose_api decorators. See Migrate legacy_expose_api* decorators to expose_api* decorators #11252.
Moved the controller logic to a manager class and added basic type hints.

jmchilton · 2021-02-17T15:09:39Z

Awesome - thanks!

davelopez added 4 commits February 16, 2021 12:49

Add some API tests for display_applications

fa7c529

Replace legacy expose_api decorator xref galaxyproject#11252

164c6ec

Rafactor API controller logic into DisplayApplicationsManager

e267111

Add type hint for Registry.display_applications

32100cf

github-actions bot added area/API area/datatypes area/testing area/testing/api labels Feb 16, 2021

github-actions bot added this to the 21.05 milestone Feb 16, 2021

davelopez added the kind/refactoring cleanup or refactoring of existing code, no functional changes label Feb 16, 2021

jmchilton merged commit 372901f into galaxyproject:dev Feb 17, 2021

davelopez deleted the refactor_display_applications_api branch February 17, 2021 15:17