Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor groups API logic into GroupsManager #11412

Merged
merged 7 commits into from
Feb 19, 2021

Conversation

davelopez
Copy link
Contributor

Overview

More work to ease the transition to FastAPI.

  • Added API tests for all endpoints
  • Replaced the old legacy_expose_api decorators.
  • Moved the controller logic to a manager class.
  • Refactored the manager to handle errors raising the appropriate exception.

Additional comments

  • I removed some of the log.info entries that looked like debug leftovers, but if they are important I can put them back :)
  • The update action was not checking that updating the name of the group could conflict with an existing name so I added the check.

@davelopez davelopez added this to the 21.05 milestone Feb 18, 2021
@davelopez davelopez added area/testing area/testing/api kind/refactoring cleanup or refactoring of existing code, no functional changes and removed area/testing area/testing/api labels Feb 18, 2021
@jmchilton jmchilton merged commit f526611 into galaxyproject:dev Feb 19, 2021
@davelopez davelopez deleted the refactor_api_groups branch February 19, 2021 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/API area/testing/api area/testing kind/refactoring cleanup or refactoring of existing code, no functional changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants