-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Copy to Clipboard button next to the tool id in job information #11478
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe that's too much decomposing, but maybe the copy button can be its own vue component ? Otherwise this is great!
I mean, we could if it's useful, do we have another usecase for this?
thanks! |
You could make this generic, so that the text to copy is being passed in. Then we have the copy button (and the styling) in a single place. It also makes the parent component slimmer, so you don't have for instance the |
no worries, I will do it now |
So I changed it to |
Thank you, that's great! |
@OlegZharkov Good call -- yes, we should use the same icon consistently |
Co-authored-by: Marius van den Beek <m.vandenbeek@gmail.com>
fixes #11473
Clipboard button next to the tool id:
Additionaly it brings generic
copy-to-clipboard
component e.g.:<copy-to-clipboard message="Tool ID was copied to your clipboard" :text="job.tool_id" />