Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[21.01] fix exporting datasets from library as collection #11625

Merged
merged 2 commits into from
Mar 16, 2021

Conversation

OlegZharkov
Copy link
Contributor

@OlegZharkov OlegZharkov commented Mar 15, 2021

For others to try, you need to apply changes from 20.09 fix here. There are 2 lines, could be done by hand untill the PR is merged

@assuntad23, can you please check this out? Is it fine?

What did you do?

Continue my #11623. Another version, another fix. The same problem, but different cause.

Why did you make this change?

fixing #11610 in 21.01

How to test the changes?

  • Instructions for manual testing are as follows:
    1. create library
    2. upload 2+ datasets
    3. export as collection

For UI Components

  • I've included a screenshot of the changes
    image

@github-actions github-actions bot added this to the 21.05 milestone Mar 15, 2021
@mvdbeek mvdbeek modified the milestones: 21.05, 21.01 Mar 16, 2021
Copy link
Member

@mvdbeek mvdbeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me, thanks @OlegZharkov!

Copy link
Member

@mvdbeek mvdbeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I pushed a small fix for the paired and list-paired creators in c9a9d4e, if that looks good we can merge

@OlegZharkov
Copy link
Contributor Author

OlegZharkov commented Mar 16, 2021

I pushed a small fix for the paired and list-paired creators in c9a9d4e, if that looks good we can merge

yes, please do. Thanks

also we would have to merge 20.09 in 21.01 and 21.01 in dev

@dannon dannon merged commit be29cab into galaxyproject:release_21.01 Mar 16, 2021
@dannon
Copy link
Member

dannon commented Mar 16, 2021

Test failures unrelated.

@github-actions
Copy link

This PR was merged without a "kind/" label, please correct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants